From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] [ETHTOOL]: Add support for large eeproms Date: Tue, 15 Apr 2008 19:24:26 -0700 (PDT) Message-ID: <20080415.192426.21456164.davem@davemloft.net> References: <48007CA0.6030002@garzik.org> <20080414180338.GA18335@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jeff@garzik.org, joe@perches.com, nil@google.com, thockin@google.com, matthew@wil.cx To: msb@google.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42320 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753549AbYDPCYa (ORCPT ); Tue, 15 Apr 2008 22:24:30 -0400 In-Reply-To: <20080414180338.GA18335@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Mandeep Singh Baines Date: Mon, 14 Apr 2008 11:03:38 -0700 > Currently, it is not possible to read/write to an eeprom larger than > 128k in size because the buffer used for temporarily storing the > eeprom contents is allocated using kmalloc. kmalloc can only allocate > a maximum of 128k depending on architecture. > > Modified ethtool_get/set_eeprom to only allocate a page of memory and > then copy the eeprom a page at a time. > > Updated original patch as per suggestions from Joe Perches. > > Signed-off-by: Mandeep Singh Baines Applied, thanks.