From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Oliver Neukum <oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>,
Paulius Zaleckas
<paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>,
ajb-5+cxppFmGx6/3pe1ocb+s/XRex20P6io@public.gmane.org
Subject: Re: [RFC] Patch to option HSO driver to the kernel
Date: Tue, 15 Apr 2008 09:06:36 -0700 [thread overview]
Message-ID: <20080415160636.GA9704@kroah.com> (raw)
In-Reply-To: <200804151344.42085.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
On Tue, Apr 15, 2008 at 01:44:40PM +0200, Oliver Neukum wrote:
> Am Montag, 14. April 2008 23:32:39 schrieb Greg KH:
> > Hi all,
> >
> > Here's a patch that I have cleaned up for context only from Option that
> > is a USB serial / network device all in one.
> >
> > I'd like to see this go into 2.6.26, so any review comments by anyone
> > who wishes to review any portion of this would be greatly apprecited.
>
> Hi,
>
> this patch against Greg's version with Pauliaus patch applied
>
> - uses correct CDC includes and constants
> - fixes a race between disconnect and open
> - fixes a race between probe and open
> - corrects incorrect uses of GFP_KERNEL
> - adds some error handling in open
> - fixes races in access to urb->status
>
> There's still a race condition in the write path left and the autosuspend
> handling is broken in extremely interesting ways. The next patch will fix
> these and I am still doing further reviews.
Thanks a lot for these changes, I've applied them to the driver.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-15 16:06 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 21:32 [RFC] Patch to option HSO driver to the kernel Greg KH
2008-04-15 4:30 ` Oliver Hartkopp
[not found] ` <48042F7F.8030608-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2008-04-15 16:11 ` Greg KH
[not found] ` <20080415161158.GE9704-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-04-15 17:53 ` Oliver Hartkopp
2008-04-15 13:55 ` Oliver Neukum
2008-04-15 16:10 ` Greg KH
[not found] ` <20080414213238.GB28833-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-04-14 21:59 ` Matthew Dharm
2008-04-14 22:42 ` Andrew Bird (Sphere Systems)
2008-04-14 23:03 ` Greg KH
[not found] ` <20080414230309.GA1672-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-04-15 8:01 ` Filip Aben
2008-04-15 15:40 ` Greg KH
2008-04-14 23:20 ` Paulius Zaleckas
2008-04-15 8:10 ` Oliver Neukum
[not found] ` <200804151010.33688.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-15 8:58 ` Paulius Zaleckas
[not found] ` <48046E4A.3060901-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-15 15:39 ` Greg KH
2008-04-15 11:44 ` Oliver Neukum
[not found] ` <200804151344.42085.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-15 16:06 ` Greg KH [this message]
2008-04-15 13:06 ` Oliver Neukum
[not found] ` <200804151506.21856.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-15 16:08 ` Greg KH
2008-04-15 16:08 ` Greg KH
2008-04-15 13:25 ` Oliver Neukum
2008-04-15 14:12 ` Filip Aben
2008-04-15 14:14 ` Oliver Neukum
2008-04-15 15:03 ` Filip Aben
2008-04-15 15:34 ` Greg KH
[not found] ` <20080415153408.GB7996-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-04-15 16:24 ` Filip Aben
2008-04-15 17:58 ` Oliver Neukum
2008-04-15 18:46 ` Oliver Neukum
[not found] ` <200804152046.44018.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-15 19:00 ` Greg KH
2008-04-15 19:14 ` Stephen Hemminger
2008-04-15 19:27 ` Greg KH
2008-04-15 20:17 ` Oliver Neukum
[not found] ` <200804152217.25451.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-15 22:18 ` Greg KH
2008-04-17 12:15 ` Oliver Neukum
2008-04-17 21:35 ` Greg KH
2008-04-15 22:49 ` Paulius Zaleckas
[not found] ` <480530E6.8020700-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-16 9:18 ` Paulius Zaleckas
[not found] ` <4805C469.7050408-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-16 11:54 ` Paulius Zaleckas
[not found] ` <4805E8E1.3090200-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-16 12:03 ` Oliver Neukum
[not found] ` <200804161403.20955.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-16 12:12 ` Paulius Zaleckas
[not found] ` <4805ED16.3080104-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-16 13:43 ` Oliver Neukum
[not found] ` <200804161543.23584.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-16 13:55 ` Paulius Zaleckas
2008-04-17 14:32 ` Oliver Neukum
[not found] ` <200804171632.12972.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-17 21:47 ` Paulius Zaleckas
[not found] ` <4807C56F.5060804-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-17 22:31 ` Chetty, Jay
2008-04-18 6:51 ` Oliver Neukum
2008-04-18 15:18 ` Paulius Zaleckas
2008-04-21 11:45 ` Oliver Neukum
2008-04-21 12:38 ` Paulius Zaleckas
[not found] ` <480C8AD8.9050609-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-21 12:50 ` Oliver Neukum
[not found] ` <200804211450.27093.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-21 13:00 ` Paulius Zaleckas
2008-04-17 21:33 ` Greg KH
2008-04-16 15:15 ` Paulius Zaleckas
2008-04-16 13:11 ` Paulius Zaleckas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415160636.GA9704@kroah.com \
--to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
--cc=ajb-5+cxppFmGx6/3pe1ocb+s/XRex20P6io@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=f.aben-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org \
--cc=paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).