From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH RFC] net/core: API to create/destroy /sys/class/net entries
Date: Thu, 17 Apr 2008 23:36:44 -0700 (PDT) [thread overview]
Message-ID: <20080417.233644.19783833.davem@davemloft.net> (raw)
In-Reply-To: <14079.1208394386@death>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Wed, 16 Apr 2008 18:06:26 -0700
> Bonding creates a file in sysfs, /sys/class/net/bonding_masters,
> which is used to create and destroy bonding devices. Currently, when
> bonding is loaded, it does some poking through the device structure of
> the first bonding device to find the net_class, and then uses that
> pointer to create the file (by calling class_create_file).
As Stephen stated this was a horrible decision, that directory is for
network device instances, that's why the class variable is called
"netdev_class" not "dump_all_yer_networking_shit_here_class"
The only saving grace is that bonding creates a file, not a
directory, so "scan for all directories under /sys/class/net/"
schemes still work.
Water under the bridge I suppose, and we're stuck with this.
I guess your proposal is the best, as if we export netdev_class
people can do other funky, undesirable, things with it.
Please submit the final version of your patch, I'll apply it.
prev parent reply other threads:[~2008-04-18 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 1:06 [PATCH RFC] net/core: API to create/destroy /sys/class/net entries Jay Vosburgh
2008-04-17 1:12 ` Stephen Hemminger
2008-04-18 6:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080417.233644.19783833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).