Re: [PATCH 0/7] Final ADSL-optimizer patch series

[Stephen Hemminger <shemminger@vyatta.com>]

On Wed, 9 Apr 2008 22:57:25 +0200 (CEST)
Jesper Dangaard Brouer <hawk@diku.dk> wrote:

> 
> This is the final part of the ADSL-optimizer patch, which is the real
> "holy grail" of packet scheduling on ADSL/ATM lines. (Referring to
> Wondershaper claim of the "holy grail".)
> 
> Shaping on ADSL has always been surrounded with mystique.  People
> reduce and tweek the upstream bandwidth, but how much and why does it
> not work all the time?  With this change, the tweeking and bandwidth
> waste is gone, simply specify the bandwidth you bought.
> 
> This patch series introduces a parameter called "linklayer", which
> currently supports "ethernet" and "atm".  Simply, what happens is,
> that the rate table is aligned for ATM cells.
> 
> This is a general implementation for all shapers, except HFSC which
> does not use rate table lookups.  Earlier (around Sep.2007), Patrick
> McHardy wanted to make an even more general patch, that also included
> HFSC. Nothing has happened since...
> 
> After talking with DaveM (at his house during an icehocky match), I've
> come to the conclusion that we have something that works now (and has
> been since Oct.2004) and we should use it!  Everybody is allowed to
> change and improve upon that. Its should not mean that we keep
> something like this back, which will allow packet scheduling to
> actually work on ADSL.  One should also realize that different shapers
> have different properties.
> 
> Patrick's further improvements can use the same userspace parameter
> "linklayer" to allow userspace parameter compatibility.
> 
> This patch series is ABI (Application Binary Interface) compatible.
> 
> See you around,
>    Jesper Brouer

Applied but:
* Used constants from atm.h, pulled in include/linux/atm.h etc.

* rolled 2-7 together in one patch.  All though small patches are preferred
  it is more important that the build doesn't break after each patch so
  if an API changes (in this case calc_rtable) fix all the functions that
  use it in one patch.

* Some mailer damage, so the patches would not apply automatically, had
  to do hand edits.