[PATCH] genetlink: export genl_unregister_mc_group()

[PATCH] genetlink: export genl_unregister_mc_group()

[Inaky Perez-Gonzalez]

Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow
unregistering groups on the run. 

Cleanup is currently done when unregistering a family, but there is
no way to unregister a single multicast group due to that function not
being exported. Seems to be a mistake as it is documented as for
external consumption.

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>

---
diff -r ec7efeb20531 net/netlink/genetlink.c
--- a/net/netlink/genetlink.c	Tue Feb 12 09:49:05 2008 -0800
+++ b/net/netlink/genetlink.c	Thu Apr 17 12:50:29 2008 -0700
@@ -225,6 +225,7 @@ void genl_unregister_mc_group(struct gen
 	__genl_unregister_mc_group(family, grp);
 	genl_unlock();
 }
+EXPORT_SYMBOL(genl_unregister_mc_group);
 
 static void genl_unregister_mc_groups(struct genl_family *family)
 {

Re: [PATCH] genetlink: export genl_unregister_mc_group()

[David Miller]

From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Date: Thu, 17 Apr 2008 12:54:01 -0700

> Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow
> unregistering groups on the run. 
> 
> Cleanup is currently done when unregistering a family, but there is
> no way to unregister a single multicast group due to that function not
> being exported. Seems to be a mistake as it is documented as for
> external consumption.
> 
> Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>

We export functions with in-tree modular users.

The only reason that genl_register_mc_group() is exported is because
there are in-tree modular users, ACPI and the NL80211 wireless code.

Please add this export when code you are writing that needs this
is merged into the tree.

Thank you.

Re: [PATCH] genetlink: export genl_unregister_mc_group()

[Inaky Perez-Gonzalez]

On Thursday 17 April 2008, David Miller wrote:
> > Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow
> > unregistering groups on the run. 
> > ..
> We export functions with in-tree modular users.
> 
> The only reason that genl_register_mc_group() is exported is because
> there are in-tree modular users, ACPI and the NL80211 wireless code.
> 
> Please add this export when code you are writing that needs this
> is merged into the tree.

Sure, 

-- 
Inaky