* [PATCH] genetlink: export genl_unregister_mc_group()
@ 2008-04-17 19:54 Inaky Perez-Gonzalez
2008-04-17 21:26 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Inaky Perez-Gonzalez @ 2008-04-17 19:54 UTC (permalink / raw)
To: Thomas Graf, Johannes Berg; +Cc: netdev
Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow
unregistering groups on the run.
Cleanup is currently done when unregistering a family, but there is
no way to unregister a single multicast group due to that function not
being exported. Seems to be a mistake as it is documented as for
external consumption.
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
---
diff -r ec7efeb20531 net/netlink/genetlink.c
--- a/net/netlink/genetlink.c Tue Feb 12 09:49:05 2008 -0800
+++ b/net/netlink/genetlink.c Thu Apr 17 12:50:29 2008 -0700
@@ -225,6 +225,7 @@ void genl_unregister_mc_group(struct gen
__genl_unregister_mc_group(family, grp);
genl_unlock();
}
+EXPORT_SYMBOL(genl_unregister_mc_group);
static void genl_unregister_mc_groups(struct genl_family *family)
{
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] genetlink: export genl_unregister_mc_group()
2008-04-17 19:54 [PATCH] genetlink: export genl_unregister_mc_group() Inaky Perez-Gonzalez
@ 2008-04-17 21:26 ` David Miller
2008-04-18 5:52 ` Inaky Perez-Gonzalez
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-04-17 21:26 UTC (permalink / raw)
To: inaky; +Cc: tgraf, johannes, netdev
From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Date: Thu, 17 Apr 2008 12:54:01 -0700
> Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow
> unregistering groups on the run.
>
> Cleanup is currently done when unregistering a family, but there is
> no way to unregister a single multicast group due to that function not
> being exported. Seems to be a mistake as it is documented as for
> external consumption.
>
> Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
We export functions with in-tree modular users.
The only reason that genl_register_mc_group() is exported is because
there are in-tree modular users, ACPI and the NL80211 wireless code.
Please add this export when code you are writing that needs this
is merged into the tree.
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] genetlink: export genl_unregister_mc_group()
2008-04-17 21:26 ` David Miller
@ 2008-04-18 5:52 ` Inaky Perez-Gonzalez
0 siblings, 0 replies; 3+ messages in thread
From: Inaky Perez-Gonzalez @ 2008-04-18 5:52 UTC (permalink / raw)
To: David Miller; +Cc: tgraf, johannes, netdev
On Thursday 17 April 2008, David Miller wrote:
> > Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow
> > unregistering groups on the run.
> > ..
> We export functions with in-tree modular users.
>
> The only reason that genl_register_mc_group() is exported is because
> there are in-tree modular users, ACPI and the NL80211 wireless code.
>
> Please add this export when code you are writing that needs this
> is merged into the tree.
Sure,
--
Inaky
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-18 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-17 19:54 [PATCH] genetlink: export genl_unregister_mc_group() Inaky Perez-Gonzalez
2008-04-17 21:26 ` David Miller
2008-04-18 5:52 ` Inaky Perez-Gonzalez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).