From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Cc: marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org,
hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org,
pavel-AlSwsSmVLrQ@public.gmane.org
Subject: Re: [patch 3/3] hci_usb.h: fix hard-to-trigger race
Date: Fri, 18 Apr 2008 15:41:07 -0700 (PDT) [thread overview]
Message-ID: <20080418.154107.112850113.davem@davemloft.net> (raw)
In-Reply-To: <20080418142153.4e0eb83b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Date: Fri, 18 Apr 2008 14:21:53 -0700
> On Fri, 18 Apr 2008 23:10:12 +0200
> Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> wrote:
>
> > Hi Andrew,
> >
> > > From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
> > >
> > > If someone tries to _urb_unlink while _urb_queue_head is running,
> > > he'll see
> > > _urb->queue == NULL and fail to do any locking. Prevent that from
> > > happening
> > > by strategically placed barriers.
> >
> > let me repeat this, the hci_usb driver is not worth fixing. Doing our
> > own URB handling is a bad idea. The btusb driver should fix all of
> > this. Only exception is that it is missing all the quirks, but that
> > was me being lazy.
> >
>
> ok... But as long as the old code is buildable and installable, we should
> fix bugs in it?
Yep.
next prev parent reply other threads:[~2008-04-18 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:46 [patch 3/3] hci_usb.h: fix hard-to-trigger race akpm
2008-04-18 21:10 ` Marcel Holtmann
[not found] ` <55DEC459-2D49-4366-88CC-21E9CA6783DC-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2008-04-18 21:21 ` Andrew Morton
[not found] ` <20080418142153.4e0eb83b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-04-18 22:41 ` David Miller [this message]
2008-04-19 1:25 ` Marcel Holtmann
2008-04-19 16:49 ` [patch] document hci_usb as broken Pavel Machek
2008-04-19 17:40 ` Marcel Holtmann
2008-04-19 17:57 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418.154107.112850113.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=pavel-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).