From: Ben Dooks <ben-linux@fluff.org>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] DM9000: __devinit/exit annotations
Date: Fri, 18 Apr 2008 11:43:46 +0100 [thread overview]
Message-ID: <20080418104346.GG15407@fluff.org.uk> (raw)
In-Reply-To: <1208512936-5897-2-git-send-email-enrico.scholz@sigma-chemnitz.de>
On Fri, Apr 18, 2008 at 12:02:15PM +0200, Enrico Scholz wrote:
> There were missing __dev* annotations for the dm9000_probe()
> and dm9000_drv_remove() functions.
>
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> drivers/net/dm9000.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index e668b37..7bc16d2 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -503,7 +503,7 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db)
> /*
> * Search DM9000 board, allocate space and register it
> */
> -static int
> +static int __devinit
> dm9000_probe(struct platform_device *pdev)
> {
> struct dm9000_plat_data *pdata = pdev->dev.platform_data;
> @@ -1376,7 +1376,7 @@ dm9000_drv_resume(struct platform_device *dev)
> return 0;
> }
>
> -static int
> +static int __devexit
> dm9000_drv_remove(struct platform_device *pdev)
> {
> struct net_device *ndev = platform_get_drvdata(pdev);
> @@ -1397,7 +1397,7 @@ static struct platform_driver dm9000_driver = {
> .owner = THIS_MODULE,
> },
> .probe = dm9000_probe,
> - .remove = dm9000_drv_remove,
> + .remove = __devexit_p(dm9000_drv_remove),
> .suspend = dm9000_drv_suspend,
> .resume = dm9000_drv_resume,
> };
> --
> 1.5.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
prev parent reply other threads:[~2008-04-18 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 10:02 [PATCH] DM9000: __devinit/exit annotations Enrico Scholz
2008-04-18 10:43 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418104346.GG15407@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).