netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] DM9000: __devinit/exit annotations
@ 2008-04-18 10:02 Enrico Scholz
  2008-04-18 10:43 ` Ben Dooks
  0 siblings, 1 reply; 2+ messages in thread
From: Enrico Scholz @ 2008-04-18 10:02 UTC (permalink / raw)
  To: netdev; +Cc: Enrico Scholz

There were missing __dev* annotations for the dm9000_probe() 
and dm9000_drv_remove() functions.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
---
 drivers/net/dm9000.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index e668b37..7bc16d2 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -503,7 +503,7 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db)
 /*
  * Search DM9000 board, allocate space and register it
  */
-static int
+static int __devinit
 dm9000_probe(struct platform_device *pdev)
 {
 	struct dm9000_plat_data *pdata = pdev->dev.platform_data;
@@ -1376,7 +1376,7 @@ dm9000_drv_resume(struct platform_device *dev)
 	return 0;
 }
 
-static int
+static int __devexit
 dm9000_drv_remove(struct platform_device *pdev)
 {
 	struct net_device *ndev = platform_get_drvdata(pdev);
@@ -1397,7 +1397,7 @@ static struct platform_driver dm9000_driver = {
 		.owner	 = THIS_MODULE,
 	},
 	.probe   = dm9000_probe,
-	.remove  = dm9000_drv_remove,
+	.remove  = __devexit_p(dm9000_drv_remove),
 	.suspend = dm9000_drv_suspend,
 	.resume  = dm9000_drv_resume,
 };
-- 
1.5.4.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] DM9000: __devinit/exit annotations
  2008-04-18 10:02 [PATCH] DM9000: __devinit/exit annotations Enrico Scholz
@ 2008-04-18 10:43 ` Ben Dooks
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2008-04-18 10:43 UTC (permalink / raw)
  To: Enrico Scholz; +Cc: netdev

On Fri, Apr 18, 2008 at 12:02:15PM +0200, Enrico Scholz wrote:
> There were missing __dev* annotations for the dm9000_probe() 
> and dm9000_drv_remove() functions.
> 
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Acked-by: Ben Dooks <ben-linux@fluff.org>

>  drivers/net/dm9000.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index e668b37..7bc16d2 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -503,7 +503,7 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db)
>  /*
>   * Search DM9000 board, allocate space and register it
>   */
> -static int
> +static int __devinit
>  dm9000_probe(struct platform_device *pdev)
>  {
>  	struct dm9000_plat_data *pdata = pdev->dev.platform_data;
> @@ -1376,7 +1376,7 @@ dm9000_drv_resume(struct platform_device *dev)
>  	return 0;
>  }
>  
> -static int
> +static int __devexit
>  dm9000_drv_remove(struct platform_device *pdev)
>  {
>  	struct net_device *ndev = platform_get_drvdata(pdev);
> @@ -1397,7 +1397,7 @@ static struct platform_driver dm9000_driver = {
>  		.owner	 = THIS_MODULE,
>  	},
>  	.probe   = dm9000_probe,
> -	.remove  = dm9000_drv_remove,
> +	.remove  = __devexit_p(dm9000_drv_remove),
>  	.suspend = dm9000_drv_suspend,
>  	.resume  = dm9000_drv_resume,
>  };
> -- 
> 1.5.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-18 10:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-18 10:02 [PATCH] DM9000: __devinit/exit annotations Enrico Scholz
2008-04-18 10:43 ` Ben Dooks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).