From: Greg KH <greg@kroah.com>
To: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: remove special ioctl from hso driver, replace by rfkill
Date: Fri, 18 Apr 2008 09:25:13 -0700 [thread overview]
Message-ID: <20080418162513.GA6704@kroah.com> (raw)
In-Reply-To: <4808A88B.4010703@teltonika.lt>
On Fri, Apr 18, 2008 at 04:56:27PM +0300, Paulius Zaleckas wrote:
> Oliver Neukum wrote:
>> Hi,
>> could you test this patch?
>> It does away with the one off serial ioctl replacing it with a standard
>> mechanism.
>> Regards
>> Oliver
>
> I have tested rfkill and it realy works, but there is two problems:
>
> - LED on the device doesn't indicate rf state... Maybe Filip knows
> some usb command to control it?
>
> - driver creates multiple rfkill entries on sysfs... This is because
> option device has multi endpoints (probe is called twice with GTM380):
You mean "multiple interfaces" :)
And that's correct, for this device, that is the way it was created, so
either rfkill entry should work to shut off the radio...
thanks,
greg k-h
next prev parent reply other threads:[~2008-04-18 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 12:28 remove special ioctl from hso driver, replace by rfkill Oliver Neukum
2008-04-16 13:06 ` Paulius Zaleckas
[not found] ` <4805F9DB.5030004-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-16 13:53 ` Oliver Neukum
2008-04-17 21:42 ` Paulius Zaleckas
2008-04-17 22:39 ` Greg KH
2008-04-17 23:28 ` Marcel Holtmann
[not found] ` <200804161428.18066.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-17 21:43 ` Greg KH
2008-04-18 13:56 ` Paulius Zaleckas
2008-04-18 16:25 ` Greg KH [this message]
2008-04-21 8:47 ` Paulius Zaleckas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418162513.GA6704@kroah.com \
--to=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@teltonika.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).