From: Matthew Wilcox <matthew@wil.cx>
To: Mark Asselstine <mark.asselstine@windriver.com>
Cc: kernel-janitors@vger.kernel.org, chas@cmf.nrl.navy.mil,
netdev@vger.kernel.org, asselsm@gmail.com
Subject: Re: [PATCH] Removal of debug code containing deprecated calls to cli()/sti()
Date: Fri, 18 Apr 2008 13:07:29 -0600 [thread overview]
Message-ID: <20080418190729.GE20637@parisc-linux.org> (raw)
In-Reply-To: <1208543806-9127-1-git-send-email-mark.asselstine@windriver.com>
On Fri, Apr 18, 2008 at 02:36:46PM -0400, Mark Asselstine wrote:
> - ns_grab_res_lock(card, flags);
> + spin_lock_irqsave(&(card)->res_lock,(flags));
We generally prefer the form:
spin_lock_irqsave(&card->res_lock, flags);
The brackets aren't needed and since they aren't used elsewhere in the
kernel, breaking the pattern makes it look like these are somehow
different (which they aren't).
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-04-18 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 14:51 [PATCH] Removal of debug code containing deprecated calls to cli()/sti() Mark Asselstine
2008-04-18 14:55 ` Chas Williams (CONTRACTOR)
2008-04-18 18:36 ` Mark Asselstine
2008-04-18 19:07 ` Matthew Wilcox [this message]
2008-04-19 1:26 ` Mark Asselstine
2008-04-19 1:30 ` Matthew Wilcox
2008-04-20 1:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418190729.GE20637@parisc-linux.org \
--to=matthew@wil.cx \
--cc=asselsm@gmail.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=kernel-janitors@vger.kernel.org \
--cc=mark.asselstine@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).