From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 2/3] hci_usb: remove code obfuscation
Date: Sat, 19 Apr 2008 00:34:30 +0200 [thread overview]
Message-ID: <20080418223430.GA13847@elf.ucw.cz> (raw)
In-Reply-To: <9BEB490E-DE8A-4018-9696-E5074CC638AC-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
On Fri 2008-04-18 23:07:10, Marcel Holtmann wrote:
> Hi Andrew,
>
>> From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
>>
>> _urb_free is an alias for kfree... making code longer & harder to
>> read. Remove it.
>
> our own URB handling here is broken anyway. It was a bad idea when we did
> it, but at that time the USB susbsystem was not in that good shape that it
> is today. So I would say leave this code as it is and concentrate on the
> new btusb driver, but if it helps anybody I am happy to ACK this one.
It currently corrupts memory (use after free) during suspend, and I'm
trying to get that fixed. It is 90% reproducible.
And yes, fixing clean code is easier.
It could be easily fixed by just not freeing the urbs during
disconnect (introducing very very slow memory leak). Would that be
acceptable?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-04-18 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:46 [patch 2/3] hci_usb: remove code obfuscation akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
2008-04-18 21:07 ` Marcel Holtmann
[not found] ` <9BEB490E-DE8A-4018-9696-E5074CC638AC-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2008-04-18 22:34 ` Pavel Machek [this message]
2008-04-19 1:28 ` Marcel Holtmann
2008-04-19 16:14 ` Pavel Machek
2008-04-19 17:43 ` Marcel Holtmann
2008-05-20 15:24 ` Pavel Machek
[not found] ` <20080520152405.GC2067-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2008-05-20 17:26 ` Marcel Holtmann
2008-05-22 22:45 ` Pavel Machek
[not found] ` <200804182046.m3IKks86014628-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-20 1:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418223430.GA13847@elf.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).