From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [bug] build failure in net/netfilter/nf_conntrack_sip.c, on latest -git
Date: Sat, 19 Apr 2008 17:54:05 -0700 (PDT) [thread overview]
Message-ID: <20080419.175405.91059921.davem@davemloft.net> (raw)
In-Reply-To: <480A2011.3080507@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Sat, 19 Apr 2008 18:38:41 +0200
> David Miller wrote:
> > From: Ingo Molnar <mingo@elte.hu>
> > Date: Sat, 19 Apr 2008 12:00:35 +0200
> >
> > [ netfilter-devel and netdev added to CC: ]
> >
> >
> >> randconfig testing found a netfilter build failure in latest -git:
> >>
> >> net/netfilter/nf_conntrack_sip.c: In function 'set_expected_rtp_rtcp':
> >> net/netfilter/nf_conntrack_sip.c:786: error: 'struct nf_conntrack_expect' has no member named 'saved_ip'
> >>
> >> http://redhat.com/~mingo/misc/config-Sat_Apr_19_11_37_02_CEST_2008.bad
> >>
> >> disabling CONFIG_NF_CONNTRACK_SIP works it around.
> >>
> >
> > I think this will fix it.
> >
> > Patrick, is this how we should do it?
>
> No, the SIP helper is also useful without NAT. This patch adds
> an ifdef around the RTP call optimization for NATed clients.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Fair enough, applied, thanks Patrick.
next prev parent reply other threads:[~2008-04-20 0:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080419100034.GA9475@elte.hu>
2008-04-19 10:07 ` [bug] build failure in net/netfilter/nf_conntrack_sip.c, on latest -git David Miller
2008-04-19 10:41 ` Ingo Molnar
2008-04-19 11:10 ` David Miller
2008-04-19 10:44 ` Jan Engelhardt
2008-04-19 11:11 ` David Miller
2008-04-19 16:38 ` Patrick McHardy
2008-04-20 0:54 ` David Miller [this message]
[not found] ` <20080419.030337.244502148.davem@davemloft.net>
[not found] ` <20080419103942.GA13599@elte.hu>
2008-04-21 8:14 ` Jeff Garzik
2008-04-21 13:39 ` Ingo Molnar
2008-04-22 2:20 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080419.175405.91059921.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).