From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Cc: marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org,
hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org,
pavel-AlSwsSmVLrQ@public.gmane.org
Subject: Re: [patch 2/3] hci_usb: remove code obfuscation
Date: Sat, 19 Apr 2008 18:16:59 -0700 (PDT) [thread overview]
Message-ID: <20080419.181659.97930825.davem@davemloft.net> (raw)
In-Reply-To: <200804182046.m3IKks86014628-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
From: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Date: Fri, 18 Apr 2008 13:46:53 -0700
> _urb_free is an alias for kfree... making code longer & harder to
> read. Remove it.
>
> Signed-off-by: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
> Cc: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
> Cc: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
As long as the code is in the tree, we should accept
simplifications that aid to code understanding.
Marking drivers broken or deprecated or to-be-replaced is
a secondary concern.
Therefore I'm applying this patch, thanks Pavel.
prev parent reply other threads:[~2008-04-20 1:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:46 [patch 2/3] hci_usb: remove code obfuscation akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
2008-04-18 21:07 ` Marcel Holtmann
[not found] ` <9BEB490E-DE8A-4018-9696-E5074CC638AC-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2008-04-18 22:34 ` Pavel Machek
2008-04-19 1:28 ` Marcel Holtmann
2008-04-19 16:14 ` Pavel Machek
2008-04-19 17:43 ` Marcel Holtmann
2008-05-20 15:24 ` Pavel Machek
[not found] ` <20080520152405.GC2067-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2008-05-20 17:26 ` Marcel Holtmann
2008-05-22 22:45 ` Pavel Machek
[not found] ` <200804182046.m3IKks86014628-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-20 1:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080419.181659.97930825.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=pavel-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).