netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: juhlenko@akamai.com
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org
Subject: Re: [RFC 0/4] net: enable timestamps on a per-socket basis
Date: Sun, 20 Apr 2008 23:03:56 -0700 (PDT)	[thread overview]
Message-ID: <20080420.230356.238029889.davem@davemloft.net> (raw)
In-Reply-To: <20080421053402.GB23476@48M1231.sanmateo.corp.akamai.com>

From: Jason Uhlenkott <juhlenko@akamai.com>
Date: Sun, 20 Apr 2008 22:34:02 -0700

> This patchset creates a mechanism for protocols to opt in to handling
> timestamps at a higher layer, and uses this mechanism to implement
> per-socket SOCK_TIMESTAMP support for several common protocols.

Moving the timestamp up to a higher level takes away some of the
frequent use cases of timestamps, which is to detect things like the
fact that it is taking a long time for packets to get from the
top-level packet receive down to the actual protocol processing.

With your patch, it can't be used that way any more.

In fact, people are desiring timestamps which are _closer_ to when the
device actually receives the frame rather than further away.

I understand the reasons why this change is desirable from a
performance standpoint, but we really can't do this, sorry.

It's probably more tenable to do the work necessary get get named to
not enable timestamps by default.  It if really wants packet data
timestamps, it can do a gettimeofday() call right after recvmsg() as
gettimeofday() is merely a function call into the VSYSCALL page on
most platforms.


  parent reply	other threads:[~2008-04-21  6:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21  5:34 [RFC 0/4] net: enable timestamps on a per-socket basis Jason Uhlenkott
2008-04-21  5:34 ` [RFC 1/4] net core: move timestamp functions Jason Uhlenkott
2008-04-21  5:35 ` [RFC 2/4] net core: let protocols implement SOCK_TIMESTAMP efficiently Jason Uhlenkott
2008-04-21  5:35 ` [RFC 3/4] ipv4: efficient SOCK_TIMESTAMP support for TCP, UDP, and raw sockets Jason Uhlenkott
2008-04-21  5:36 ` [RFC 4/4] af_packet: efficient SOCK_TIMESTAMP support Jason Uhlenkott
2008-04-21  6:03 ` David Miller [this message]
2008-04-21  7:28   ` [RFC 0/4] net: enable timestamps on a per-socket basis Jason Uhlenkott
2008-04-21 10:44   ` Andi Kleen
2008-04-21 10:59     ` David Miller
2008-04-21 11:43       ` Andi Kleen
2008-04-21 11:51         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080420.230356.238029889.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=juhlenko@akamai.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).