From: Grant Grundler <grundler@parisc-linux.org>
To: jgarzik@pobox.com, David Dillow <dave@thedillows.org>
Cc: netdev@vger.kernel.org
Subject: [PATCH] 2.6.25 typhoon_resume - remove call to start_queue
Date: Sun, 20 Apr 2008 22:44:15 -0600 [thread overview]
Message-ID: <20080421044415.GB15080@colo.lackof.org> (raw)
Jeff,
While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952
I looked at a few other drivers to figure out what drivers _should_
be doing for suspend/resume. I noticed typhoon driver is likely doing
more than it needs to. Patch below is untested since I don't have the HW.
Suspend/resume code across NIC drivers is fairly inconsistent.
And I couldn't find any documentation on what the canonical sequence
NICs need to do for suspend or resume. Is there any?
Barring contrary advice, I'm going model the tulip suspend/resume
fixes after tg3.c since a number of "modern" (< 5 years old) laptops
have that and I'm silly enough to assume it works.
thanks,
grant
---
Comments/code in netif_device_attach() suggest it is restarting the queue.
Thus, typhoon_resume() doesn't need to call start_queue().
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index 333961b..c0dd25b 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev)
}
netif_device_attach(dev);
- netif_start_queue(dev);
return 0;
reset:
next reply other threads:[~2008-04-21 4:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 4:44 Grant Grundler [this message]
2008-04-21 5:57 ` [PATCH] 2.6.25 typhoon_resume - remove call to start_queue David Miller
2008-04-21 14:35 ` David Dillow
2008-04-25 6:01 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421044415.GB15080@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=dave@thedillows.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).