[build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'

[build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'

[Ingo Molnar]

> and after i restarted last night's QA run, within a few iterations a 
> fourth build failure popped up:

and here's a fifth build failure in the networking code, triggered in 
our testing:

  net/built-in.o: In function `sctp_manip_pkt':
  nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'
  nf_nat_proto_sctp.c:(.text+0x6d180): undefined reference to `crc32c_le'
  nf_nat_proto_sctp.c:(.text+0x6d196): undefined reference to `crc32c_le'
  nf_nat_proto_sctp.c:(.text+0x6d1c6): undefined reference to `crc32c_le'

  http://redhat.com/~mingo/misc/config-Mon_Apr_21_01_52_14_CEST_2008.bad

	Ingo

Re: [build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'

[David Miller]

From: Ingo Molnar <mingo@elte.hu>
Date: Mon, 21 Apr 2008 08:22:44 +0200

>   net/built-in.o: In function `sctp_manip_pkt':
>   nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'
>   nf_nat_proto_sctp.c:(.text+0x6d180): undefined reference to `crc32c_le'
>   nf_nat_proto_sctp.c:(.text+0x6d196): undefined reference to `crc32c_le'
>   nf_nat_proto_sctp.c:(.text+0x6d1c6): undefined reference to `crc32c_le'
> 
>   http://redhat.com/~mingo/misc/config-Mon_Apr_21_01_52_14_CEST_2008.bad

Thanks for your report Ingo.

Patrick, I'm not so sure how to fix this, or even what's wrong.

NF_NAT_PROTO_SCTP does a proper select on LIBCRC32C, but somehow
NF_NAT_PROTO_SCTP=y and LIBCRC32C=m.

I notice that IP_SCTP=m in this config.  So perhaps the issue is the
case where two features do a select on an infrastructure config
option.  Maybe whoever does the last 'select' gets to decide if the
option gets set to 'y' or 'm'?

It's just a guess, as I still for the life of me can't figure out
how these dependencies get sorted by the kbuild system in situations
like this.

Re: [build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'

[Adrian Bunk]

On Sun, Apr 20, 2008 at 11:53:54PM -0700, David Miller wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Mon, 21 Apr 2008 08:22:44 +0200
> 
> >   net/built-in.o: In function `sctp_manip_pkt':
> >   nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'
> >   nf_nat_proto_sctp.c:(.text+0x6d180): undefined reference to `crc32c_le'
> >   nf_nat_proto_sctp.c:(.text+0x6d196): undefined reference to `crc32c_le'
> >   nf_nat_proto_sctp.c:(.text+0x6d1c6): undefined reference to `crc32c_le'
> > 
> >   http://redhat.com/~mingo/misc/config-Mon_Apr_21_01_52_14_CEST_2008.bad
> 
> Thanks for your report Ingo.
> 
> Patrick, I'm not so sure how to fix this, or even what's wrong.
> 
> NF_NAT_PROTO_SCTP does a proper select on LIBCRC32C, but somehow
> NF_NAT_PROTO_SCTP=y and LIBCRC32C=m.
>...

You added the select on Saturday after Pete Clements reported the same 
issue.

The select is not yet in Linus' tree.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'

[David Miller]

From: Adrian Bunk <bunk@kernel.org>
Date: Mon, 21 Apr 2008 11:44:02 +0300

> On Sun, Apr 20, 2008 at 11:53:54PM -0700, David Miller wrote:
> > From: Ingo Molnar <mingo@elte.hu>
> > Date: Mon, 21 Apr 2008 08:22:44 +0200
> > 
> > >   net/built-in.o: In function `sctp_manip_pkt':
> > >   nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'
> > >   nf_nat_proto_sctp.c:(.text+0x6d180): undefined reference to `crc32c_le'
> > >   nf_nat_proto_sctp.c:(.text+0x6d196): undefined reference to `crc32c_le'
> > >   nf_nat_proto_sctp.c:(.text+0x6d1c6): undefined reference to `crc32c_le'
> > > 
> > >   http://redhat.com/~mingo/misc/config-Mon_Apr_21_01_52_14_CEST_2008.bad
> > 
> > Thanks for your report Ingo.
> > 
> > Patrick, I'm not so sure how to fix this, or even what's wrong.
> > 
> > NF_NAT_PROTO_SCTP does a proper select on LIBCRC32C, but somehow
> > NF_NAT_PROTO_SCTP=y and LIBCRC32C=m.
> >...
> 
> You added the select on Saturday after Pete Clements reported the same 
> issue.
> 
> The select is not yet in Linus' tree.

Thanks for catching that Adrian.

Re: [build bug] nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'

[Patrick McHardy]

David Miller wrote:
> From: Adrian Bunk <bunk@kernel.org>
> Date: Mon, 21 Apr 2008 11:44:02 +0300
> 
>> On Sun, Apr 20, 2008 at 11:53:54PM -0700, David Miller wrote:
>>> From: Ingo Molnar <mingo@elte.hu>
>>> Date: Mon, 21 Apr 2008 08:22:44 +0200
>>>
>>>>   net/built-in.o: In function `sctp_manip_pkt':
>>>>   nf_nat_proto_sctp.c:(.text+0x6d173): undefined reference to `crc32c_le'
>>>>   nf_nat_proto_sctp.c:(.text+0x6d180): undefined reference to `crc32c_le'
>>>>   nf_nat_proto_sctp.c:(.text+0x6d196): undefined reference to `crc32c_le'
>>>>   nf_nat_proto_sctp.c:(.text+0x6d1c6): undefined reference to `crc32c_le'
>>>>
>>>>   http://redhat.com/~mingo/misc/config-Mon_Apr_21_01_52_14_CEST_2008.bad
>>> Thanks for your report Ingo.
>>>
>>> Patrick, I'm not so sure how to fix this, or even what's wrong.
>>>
>>> NF_NAT_PROTO_SCTP does a proper select on LIBCRC32C, but somehow
>>> NF_NAT_PROTO_SCTP=y and LIBCRC32C=m.
>>> ...
>> You added the select on Saturday after Pete Clements reported the same 
>> issue.
>>
>> The select is not yet in Linus' tree.
> 
> Thanks for catching that Adrian.

I've verified that Saturday's patch results in a correct looking
config, with

CONFIG_NF_NAT_PROTO_SCTP=y
CONFIG_LIBCRC32C=y