From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: paulkf@microgate.com, khc@pm.waw.pl, jchapman@katalix.com,
alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC
Date: Tue, 22 Apr 2008 15:05:59 -0700 (PDT) [thread overview]
Message-ID: <20080422.150559.115368150.davem@davemloft.net> (raw)
In-Reply-To: <480E4FA1.5020508@garzik.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Tue, 22 Apr 2008 16:50:41 -0400
> The fact that Krzysztof's solution was _small_ and _clean_ and easily
> maintainable was the reason I merged it [into my tree].
>
> IMO sometimes "one size fits all" is not the best solution.
This is besides the point. We are discussing two things here:
1) How to "correctly" fix the syncppp private area bug.
2) How to, long term, support PPP properly in the kernel for
various users.
The fact that non-HDLC users of syncppp got left broken is why I
objected to the change you merged in Jeff. It simply duplicated the
majority of syncppp into the HDLC PPP code, which is just rediculious.
That had nothing to do with whether we should, in the long term, use
the generic PPP infrastructure we have now.
I would have been more than happy if syncppp was retained and fixed
properly, instead of being abandoned and duplicated in one fell swoop.
We don't do things like that Jeff.
next prev parent reply other threads:[~2008-04-22 22:05 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 18:21 WAN: new PPP code for generic HDLC Krzysztof Halasa
2008-03-12 18:30 ` [PATCH] " Krzysztof Halasa
2008-03-12 18:52 ` Stephen Hemminger
2008-03-12 19:25 ` Krzysztof Halasa
2008-03-12 19:38 ` Jan Engelhardt
2008-03-12 20:10 ` Krzysztof Halasa
2008-03-12 22:12 ` Jan Engelhardt
2008-03-14 14:16 ` Krzysztof Halasa
2008-03-14 14:20 ` [PATCH v2] " Krzysztof Halasa
2008-03-25 14:39 ` Krzysztof Halasa
2008-03-25 14:55 ` Jeff Garzik
2008-03-25 15:50 ` Krzysztof Halasa
2008-03-26 23:05 ` Krzysztof Halasa
2008-03-25 23:14 ` David Miller
2008-03-26 15:01 ` Krzysztof Halasa
2008-04-11 21:35 ` Krzysztof Halasa
2008-04-12 5:14 ` Andrew Morton
2008-04-12 8:10 ` Krzysztof Halasa
2008-04-12 8:50 ` Jeff Garzik
2008-04-12 19:25 ` Krzysztof Halasa
2008-04-12 10:59 ` Alan Cox
2008-04-12 20:19 ` Krzysztof Halasa
2008-04-14 19:16 ` Waskiewicz Jr, Peter P
2008-04-14 21:09 ` David Miller
2008-04-18 15:58 ` Krzysztof Halasa
2008-04-18 22:32 ` David Miller
2008-04-21 15:30 ` Krzysztof Halasa
2008-04-21 19:31 ` James Chapman
2008-04-22 19:06 ` Krzysztof Halasa
2008-04-22 21:46 ` Paul Fulghum
2008-04-22 20:50 ` Jeff Garzik
2008-04-22 22:05 ` David Miller [this message]
2008-04-23 17:02 ` Krzysztof Halasa
2008-04-23 22:49 ` David Miller
2008-04-24 0:48 ` Krzysztof Halasa
2008-04-24 1:08 ` David Miller
2008-04-24 13:12 ` Krzysztof Halasa
2008-04-24 13:30 ` David Miller
2008-04-24 13:39 ` Krzysztof Halasa
2008-04-24 13:55 ` David Miller
2008-04-24 20:46 ` Krzysztof Halasa
2008-04-24 20:44 ` Alan Cox
2008-04-25 11:10 ` Krzysztof Halasa
2008-05-12 10:32 ` David Miller
2008-05-14 12:45 ` Krzysztof Halasa
2008-05-19 17:00 ` [PATCH] WAN: protect HDLC proto list while insmod/rmmod Krzysztof Halasa
2008-05-19 21:06 ` David Miller
2008-05-22 10:27 ` Jeff Garzik
2008-05-14 16:17 ` [PATCH v2] Re: WAN: new PPP code for generic HDLC Krzysztof Halasa
2008-04-24 20:50 ` Krzysztof Halasa
2008-04-22 22:23 ` James Chapman
2008-04-22 22:51 ` David Miller
2008-04-22 22:02 ` David Miller
2008-04-22 23:52 ` Paul Fulghum
2008-04-12 9:12 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422.150559.115368150.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jchapman@katalix.com \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).