From: David Miller <davem@davemloft.net>
To: khc@pm.waw.pl
Cc: jeff@garzik.org, paulkf@microgate.com, jchapman@katalix.com,
alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC
Date: Wed, 23 Apr 2008 18:08:49 -0700 (PDT) [thread overview]
Message-ID: <20080423.180849.240014014.davem@davemloft.net> (raw)
In-Reply-To: <m3iqy8f57m.fsf@maximus.localdomain>
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Thu, 24 Apr 2008 02:48:29 +0200
> David Miller <davem@davemloft.net> writes:
>
> > No, it was added as an optimization since the private
> > area was allocated together with the struct netdev, and
> > thus at a constant offset computable a compile time.
>
> That's essentially what I meant. And it has changed, call it whatever
> you wish.
The core kernel code sets dev->priv to the alloc_netdev() allocated
memory region.
It doesn't do that just for fun.
Any code which overrides that setting is asking for trouble.
What if the code kernel code that set it, needed to use it
during device release for some reason?
next prev parent reply other threads:[~2008-04-24 1:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 18:21 WAN: new PPP code for generic HDLC Krzysztof Halasa
2008-03-12 18:30 ` [PATCH] " Krzysztof Halasa
2008-03-12 18:52 ` Stephen Hemminger
2008-03-12 19:25 ` Krzysztof Halasa
2008-03-12 19:38 ` Jan Engelhardt
2008-03-12 20:10 ` Krzysztof Halasa
2008-03-12 22:12 ` Jan Engelhardt
2008-03-14 14:16 ` Krzysztof Halasa
2008-03-14 14:20 ` [PATCH v2] " Krzysztof Halasa
2008-03-25 14:39 ` Krzysztof Halasa
2008-03-25 14:55 ` Jeff Garzik
2008-03-25 15:50 ` Krzysztof Halasa
2008-03-26 23:05 ` Krzysztof Halasa
2008-03-25 23:14 ` David Miller
2008-03-26 15:01 ` Krzysztof Halasa
2008-04-11 21:35 ` Krzysztof Halasa
2008-04-12 5:14 ` Andrew Morton
2008-04-12 8:10 ` Krzysztof Halasa
2008-04-12 8:50 ` Jeff Garzik
2008-04-12 19:25 ` Krzysztof Halasa
2008-04-12 10:59 ` Alan Cox
2008-04-12 20:19 ` Krzysztof Halasa
2008-04-14 19:16 ` Waskiewicz Jr, Peter P
2008-04-14 21:09 ` David Miller
2008-04-18 15:58 ` Krzysztof Halasa
2008-04-18 22:32 ` David Miller
2008-04-21 15:30 ` Krzysztof Halasa
2008-04-21 19:31 ` James Chapman
2008-04-22 19:06 ` Krzysztof Halasa
2008-04-22 21:46 ` Paul Fulghum
2008-04-22 20:50 ` Jeff Garzik
2008-04-22 22:05 ` David Miller
2008-04-23 17:02 ` Krzysztof Halasa
2008-04-23 22:49 ` David Miller
2008-04-24 0:48 ` Krzysztof Halasa
2008-04-24 1:08 ` David Miller [this message]
2008-04-24 13:12 ` Krzysztof Halasa
2008-04-24 13:30 ` David Miller
2008-04-24 13:39 ` Krzysztof Halasa
2008-04-24 13:55 ` David Miller
2008-04-24 20:46 ` Krzysztof Halasa
2008-04-24 20:44 ` Alan Cox
2008-04-25 11:10 ` Krzysztof Halasa
2008-05-12 10:32 ` David Miller
2008-05-14 12:45 ` Krzysztof Halasa
2008-05-19 17:00 ` [PATCH] WAN: protect HDLC proto list while insmod/rmmod Krzysztof Halasa
2008-05-19 21:06 ` David Miller
2008-05-22 10:27 ` Jeff Garzik
2008-05-14 16:17 ` [PATCH v2] Re: WAN: new PPP code for generic HDLC Krzysztof Halasa
2008-04-24 20:50 ` Krzysztof Halasa
2008-04-22 22:23 ` James Chapman
2008-04-22 22:51 ` David Miller
2008-04-22 22:02 ` David Miller
2008-04-22 23:52 ` Paul Fulghum
2008-04-12 9:12 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423.180849.240014014.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jchapman@katalix.com \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).