From: David Miller <davem@davemloft.net>
To: matheos.worku@sun.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] [NIU] Add support for Neptune FEM/NEM cards for C10 server blades
Date: Wed, 23 Apr 2008 18:30:22 -0700 (PDT) [thread overview]
Message-ID: <20080423.183022.52374157.davem@davemloft.net> (raw)
In-Reply-To: <200804231812.m3NICPCL047978@sr1-umpk-33.sfbay.sun.com>
From: Matheos Worku <matheos.worku@sun.com>
Date: Wed, 23 Apr 2008 10:17:40 -0700
> @@ -3243,6 +3245,7 @@ struct niu {
> struct timer_list timer;
> const struct niu_phy_ops *phy_ops;
> int phy_addr;
> + int hotplug_phy_present;
> struct niu_link_config link_config;
>
> struct work_struct reset_task;
Using a full integer for boolean state is wasteful, please
just add another state flag to niu->flags
Thank you.
next parent reply other threads:[~2008-04-24 1:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804231812.m3NICPCL047978@sr1-umpk-33.sfbay.sun.com>
2008-04-24 1:30 ` David Miller [this message]
2008-04-24 19:46 ` [PATCH 2/2] [NIU] Add support for Neptune FEM/NEM cards for C10 server blades Matheos Worku
2008-04-25 4:10 ` David Miller
2008-04-23 18:16 Matheos Worku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423.183022.52374157.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=matheos.worku@sun.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).