From: Jarek Poplawski <jarkao2@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Stephen Hemminger <stephen.hemminger@vyatta.com>,
Kieran Mansley <kmansley@solarflare.com>,
Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org
Subject: Re: LRO/GSO interaction when packets are forwarded
Date: Wed, 23 Apr 2008 10:38:10 +0000 [thread overview]
Message-ID: <20080423103809.GB3994@ff.dom.local> (raw)
In-Reply-To: <20080423100702.GS21637@solarflare.com>
On Wed, Apr 23, 2008 at 11:07:04AM +0100, Ben Hutchings wrote:
> Jarek Poplawski wrote:
> > On Wed, Apr 23, 2008 at 06:00:18AM +0000, Jarek Poplawski wrote:
> > > On 23-04-2008 01:01, Stephen Hemminger wrote:
> > > ...
> > > >>>> First off, no hardware should ever do LRO on non-local packets. If the
> > > >>>> hardware isn't smart enough to do this, I guess the bridge code to have
> > > >>>> an API to turn it off. IP should also turn it off if ip_forwarding
> > > >>>> is enabled on that device.
> > >
> > > Could you explain this more? (I can't see any obvious reason why
> > > forwarding between local networks should differ here from bridging?)
> >
> > ...and the second question: is only ip_forwarding flag checking right
> > way to disable something destined for local packets?
>
> "Non-local" here simply means destined for another host. It doesn't
> matter whether that host is on the same LAN or not.
Thanks for explanation! I'd still like to know why it's wrong, and
why we should turn this off on a device with ip_forwarding enabled
without checking how smart this hardware is?
Regards,
Jarek P.
next prev parent reply other threads:[~2008-04-23 10:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 14:09 LRO/GSO interaction when packets are forwarded Kieran Mansley
2008-03-07 16:25 ` Stephen Hemminger
2008-03-07 17:06 ` Kieran Mansley
2008-03-07 21:43 ` [PATCH] ethtool: command line support for lro Stephen Hemminger
2008-03-10 18:07 ` Ben Hutchings
2008-03-10 18:29 ` Stephen Hemminger
2008-03-10 18:50 ` Ben Hutchings
2008-04-17 12:11 ` Ben Hutchings
2008-04-30 18:36 ` Kok, Auke
2008-05-02 14:34 ` Ben Hutchings
2008-09-14 2:09 ` Jeff Garzik
2008-03-11 16:50 ` LRO/GSO interaction when packets are forwarded Kieran Mansley
2008-04-22 21:15 ` Ben Hutchings
2008-04-22 23:01 ` Stephen Hemminger
2008-04-23 6:00 ` Jarek Poplawski
2008-04-23 6:15 ` Jarek Poplawski
2008-04-23 10:07 ` Ben Hutchings
2008-04-23 10:38 ` Jarek Poplawski [this message]
2008-04-23 10:42 ` David Miller
2008-04-23 11:09 ` Jarek Poplawski
2008-04-23 10:04 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423103809.GB3994@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=kmansley@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).