From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, stephen.hemminger@vyatta.com,
kmansley@solarflare.com, shemminger@vyatta.com,
netdev@vger.kernel.org
Subject: Re: LRO/GSO interaction when packets are forwarded
Date: Wed, 23 Apr 2008 11:09:43 +0000 [thread overview]
Message-ID: <20080423110942.GC3994@ff.dom.local> (raw)
In-Reply-To: <20080423.034225.176998769.davem@davemloft.net>
On Wed, Apr 23, 2008 at 03:42:25AM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Wed, 23 Apr 2008 10:38:10 +0000
>
> > Thanks for explanation! I'd still like to know why it's wrong, and
> > why we should turn this off on a device with ip_forwarding enabled
> > without checking how smart this hardware is?
>
> It's not about how smart the hardware is.
...I think Stephen mentioned there could be some difference?
>
> This a stateless feature, the device accumulates data into
> large receive frames when it's TCP and the ports and addresses
> match.
>
> There is no knowledge of routes or anything like that, nor should
> there be, because otherwise it would cease to be stateless.
OK, but bridging doesn't seem to need much more... But, anyway, why
(with such a smart hardware) it should be impossible to get such
local LRO packets, and do ip forwarding (with non-LRO non-local
packets)?
Thanks,
Jarek P.
next prev parent reply other threads:[~2008-04-23 11:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 14:09 LRO/GSO interaction when packets are forwarded Kieran Mansley
2008-03-07 16:25 ` Stephen Hemminger
2008-03-07 17:06 ` Kieran Mansley
2008-03-07 21:43 ` [PATCH] ethtool: command line support for lro Stephen Hemminger
2008-03-10 18:07 ` Ben Hutchings
2008-03-10 18:29 ` Stephen Hemminger
2008-03-10 18:50 ` Ben Hutchings
2008-04-17 12:11 ` Ben Hutchings
2008-04-30 18:36 ` Kok, Auke
2008-05-02 14:34 ` Ben Hutchings
2008-09-14 2:09 ` Jeff Garzik
2008-03-11 16:50 ` LRO/GSO interaction when packets are forwarded Kieran Mansley
2008-04-22 21:15 ` Ben Hutchings
2008-04-22 23:01 ` Stephen Hemminger
2008-04-23 6:00 ` Jarek Poplawski
2008-04-23 6:15 ` Jarek Poplawski
2008-04-23 10:07 ` Ben Hutchings
2008-04-23 10:38 ` Jarek Poplawski
2008-04-23 10:42 ` David Miller
2008-04-23 11:09 ` Jarek Poplawski [this message]
2008-04-23 10:04 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423110942.GC3994@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=kmansley@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).