From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-2.6.26 (Plan B)] [TCP]: Lower stack usage in tcp4_seq_show().
Date: Thu, 24 Apr 2008 01:02:36 -0700 (PDT) [thread overview]
Message-ID: <20080424.010236.189297164.davem@davemloft.net> (raw)
In-Reply-To: <480DF7BE.5030803@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 22 Apr 2008 18:35:42 +0400
> YOSHIFUJI Hideaki wrote:
> > tcp4_seq_show() eats about 250 bytes. By using buffer in seq_file
> > directly, it will be reduced around 100 bytes.
> >
> > One drawback is higher usage of slab for IPv6 but the format
> > will not change with this patch.
> >
> > Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
>
> Plan C: we can follow the Al Viro's proposal about %n like in this patch.
> The same applies to udp, fib (the /proc/net/route file), rt_cache and
> sctp debug. This is minus ~150-200 bytes for each.
>
> How do you think?
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
To me, this looks great. Thanks everyone for working on this.
Patch applied.
prev parent reply other threads:[~2008-04-24 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 10:33 [RFC PATCH net-2.6.26 (Plan B)] [TCP]: Lower stack usage in tcp4_seq_show() YOSHIFUJI Hideaki / 吉藤英明
2008-04-22 14:35 ` Pavel Emelyanov
2008-04-24 8:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424.010236.189297164.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).