From: Christoph Hellwig <hch@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [patch 10/15] m68k: Some network drivers do not check the platform
Date: Thu, 24 Apr 2008 14:42:56 -0400 [thread overview]
Message-ID: <20080424184256.GA8531@infradead.org> (raw)
In-Reply-To: <20080424183242.943446357@mail.of.borg>
On Thu, Apr 24, 2008 at 08:29:50PM +0200, Geert Uytterhoeven wrote:
> +++ b/drivers/net/macmace.c
> @@ -781,6 +781,9 @@ static int __init mac_mace_init_module(v
> {
> int err;
>
> + if (!MACH_IS_MAC)
> + return -ENODEV;
> +
> if ((err = platform_driver_register(&mac_mace_driver))) {
> printk(KERN_ERR "Driver registration failed\n");
> return err;
This is rather odd. The whole point of the platform_driver
infrastructure is that the arch code only registers it if it's present
and then the driver can match for it. So the right fix here is to move
the platform_driver_register(&mac_mace_driver) into the mac arch setup
code. A quick grep shows this is a quite common pattern for m68k
drivers.
next prev parent reply other threads:[~2008-04-24 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080424182940.424312704@mail.of.borg>
2008-04-24 18:29 ` [patch 10/15] m68k: Some network drivers do not check the platform Geert Uytterhoeven
2008-04-24 18:42 ` Christoph Hellwig [this message]
2008-04-24 18:51 ` Geert Uytterhoeven
2008-04-24 17:54 ` Brad Boyer
2008-04-24 18:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424184256.GA8531@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).