From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: dlstevens@us.ibm.com, netdev@vger.kernel.org
Subject: Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit kernels.
Date: Fri, 25 Apr 2008 22:32:36 -0700 (PDT) [thread overview]
Message-ID: <20080425.223236.81693355.davem@davemloft.net> (raw)
In-Reply-To: <20080426.135337.101775890.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Date: Sat, 26 Apr 2008 13:53:37 +0900 (JST)
> In article <OF326F3AF9.7322F5FB-ON88257437.00174874-88257437.00194F7B@us.ibm.com> (at Fri, 25 Apr 2008 21:36:29 -0700), David Stevens <dlstevens@us.ibm.com> says:
>
> > > net/compat.c is not the right place.
> > > Please put this in net/ipv4/compat.c or so.
> > > Or at least, these must be guarded by CONFIG_INET.
> >
> > This code is for both v4 and v6, so I'd rather it not be in
> > net/ipv4/compat.c. I didn't try without CONFIG_INET, -- will look
> > at that.
>
> We've been putting ipv4/ipv6 common things in net/ipv4/*.c,
> so please put it in net/ipv4/compat.c.
I see no reason not to put this in net/compat.c, it's acting
like fs/compat_ioctl.c which even has networking compat
ioctls implemented there, among other things ;-)
next prev parent reply other threads:[~2008-04-26 5:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 8:02 [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit kernels YOSHIFUJI Hideaki / 吉藤英明
2008-04-24 8:08 ` David Miller
2008-04-24 8:16 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-24 8:49 ` David Miller
2008-04-24 9:28 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-24 9:35 ` David Miller
2008-04-24 18:46 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-24 20:01 ` David Stevens
2008-04-24 20:43 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-24 20:59 ` David Stevens
2008-04-24 17:52 ` David Stevens
2008-04-25 5:38 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-25 6:23 ` David Stevens
2008-04-25 6:27 ` David Miller
2008-04-25 6:31 ` David Miller
2008-04-25 6:37 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-25 6:47 ` David Miller
2008-04-25 6:59 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-25 7:04 ` David Miller
2008-04-25 7:24 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-26 0:24 ` David Stevens
2008-04-26 3:33 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-26 4:36 ` David Stevens
2008-04-26 4:53 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-26 5:32 ` David Miller [this message]
2008-04-26 5:56 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-26 6:01 ` David Miller
2008-04-26 6:25 ` David Stevens
2008-04-26 6:31 ` David Miller
2008-04-26 7:13 ` David Stevens
2008-04-26 9:07 ` David Miller
2008-04-26 5:09 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-26 5:31 ` David Miller
2008-04-26 7:00 ` David Stevens
2008-04-26 7:09 ` David Miller
2008-04-26 23:55 ` David Stevens
2008-04-27 8:06 ` David Miller
2008-04-26 5:14 ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-26 5:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080425.223236.81693355.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).