From: David Miller <davem@davemloft.net>
To: jason@acm.org
Cc: yi.zhu@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Allow building iwl3945 without iwl4965.
Date: Sun, 27 Apr 2008 15:43:08 -0700 (PDT) [thread overview]
Message-ID: <20080427.154308.207402253.davem@davemloft.net> (raw)
In-Reply-To: <87zlrgl09s.fsf@sparse.dyndns.org>
From: Jason Riedy <jason@acm.org>
Date: Sat, 26 Apr 2008 15:27:43 -0700
> If IWL3945 ever depends on IWLCORE, the silent, user-invisible
> IWLWIFI option can go away.
>
> Signed-off-by: Jason Riedy <jason@acm.org>
Patch applied, thanks a lot jason.
> The breakage made it to Linus's tree but isn't in the wireless forest
> (as far as I can see). Commit 49186b4a083655 is a "part 2" without
> a "part 1", so perhaps that "part 1" avoided the problem?
No, the "part 1" is exactly the patch posted by Tomas Winkler
and referenced in the 49186b4a083655 commit, which is:
commit d7d313000ba2fc94a5383511a17ff38a39bab928
Author: Tomas Winkler <tomas.winkler@intel.com>
Date: Wed Apr 23 03:48:57 2008 -0700
iwlwifi: Fix built-in compilation of iwlcore
This patch fixes problem in Makefile that prevented
built-in compilation of iwlcore
Commit that caused this problem: eadd3c4b ("iwlwifi: make Makefile
more concise")
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Yi Zhu <yi.zhu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/wireless/iwlwifi/Makefile b/drivers/net/wireless/iwlwifi/Makefile
index 4f3e88b..ec6187b 100644
--- a/drivers/net/wireless/iwlwifi/Makefile
+++ b/drivers/net/wireless/iwlwifi/Makefile
@@ -1,4 +1,4 @@
-obj-$(CONFIG_IWLCORE) := iwlcore.o
+obj-$(CONFIG_IWLCORE) += iwlcore.o
iwlcore-objs := iwl-core.o iwl-eeprom.o iwl-hcmd.o
iwlcore-$(CONFIG_IWLWIFI_DEBUGFS) += iwl-debugfs.o
iwlcore-$(CONFIG_IWLWIFI_LEDS) += iwl-led.o
next prev parent reply other threads:[~2008-04-27 22:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 22:27 [PATCH] Allow building iwl3945 without iwl4965 Jason Riedy
2008-04-27 22:43 ` David Miller [this message]
2008-04-29 2:19 ` Zhu Yi
2008-04-29 13:27 ` John W. Linville
2008-04-30 2:14 ` Zhu Yi
2008-04-30 2:17 ` David Miller
2008-04-30 2:31 ` Zhu Yi
2008-04-30 2:32 ` David Miller
2008-04-30 4:46 ` Bill Fink
2008-04-30 2:36 ` Randy.Dunlap
2008-04-30 9:34 ` Zhu Yi
2008-05-02 15:07 ` Sam Ravnborg
2008-05-04 1:50 ` Zhu Yi
2008-05-05 18:25 ` [2.6 patch] make IWLWIFI a tristate Adrian Bunk
2008-05-05 19:40 ` David Miller
2008-05-05 19:42 ` Adrian Bunk
2008-05-06 1:26 ` Zhu Yi
2008-05-06 7:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080427.154308.207402253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jason@acm.org \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).