From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org
Subject: Re: useless tcp maybe-bug report
Date: Mon, 28 Apr 2008 02:01:23 -0700 (PDT) [thread overview]
Message-ID: <20080428.020123.07945936.davem@davemloft.net> (raw)
In-Reply-To: <20080428014049.eee1a533.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Mon, 28 Apr 2008 01:40:49 -0700
> I just fired up latest mainline plus the 300-odd patches which I'm about to
> send Linuswards on a mac g5.
>
> I use that g5 as a distcc server. I'm now seeing this:
>
> distcc[13554] (dcc_writex) ERROR: failed to write: Connection reset by peer
> distcc[13554] (dcc_writex) ERROR: failed to write: Broken pipe
> distcc[13554] Warning: failed to distribute net/atm/clip.mod.c to g5/32, running locally instead
>
> about once per allmodconfig build. The client kernel is 2.6.24.3-34.fc8
> and has never changed.
>
> Thing is, these messages are unusual. I suspect that Something Is Up with
> that g5, perhaps its networking.
>
> There are no signs of problems in the g5's dmesg.
I bet your fc8 kernel has the bug that needs this patch below.
The bug causes timewait sockets to reset erroneously and matches your
symptoms precisely.
commit 7951f0b03a63d657c72c7d54d306ef3357e7e604
Author: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Thu Apr 10 20:53:10 2008 -0700
[NETNS][IPV6] tcp - assign the netns for timewait sockets
Copy the network namespace from the socket to the timewait socket.
Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Acked-by: Mark Lord <mlord@pobox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c
index 876169f..717c411 100644
--- a/net/ipv4/inet_timewait_sock.c
+++ b/net/ipv4/inet_timewait_sock.c
@@ -124,6 +124,7 @@ struct inet_timewait_sock *inet_twsk_alloc(const struct sock *sk, const int stat
tw->tw_hash = sk->sk_hash;
tw->tw_ipv6only = 0;
tw->tw_prot = sk->sk_prot_creator;
+ tw->tw_net = sk->sk_net;
atomic_set(&tw->tw_refcnt, 1);
inet_twsk_dead_node_init(tw);
__module_get(tw->tw_prot->owner);
prev parent reply other threads:[~2008-04-28 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 8:40 useless tcp maybe-bug report Andrew Morton
2008-04-28 9:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428.020123.07945936.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).