Netdev List
 help / color / mirror / Atom feed
From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: dlstevens@us.ibm.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] add compat support for getsockopt (MCAST_MSFILTER)
Date: Mon, 28 Apr 2008 15:36:50 +0900 (JST)	[thread overview]
Message-ID: <20080428.153650.57555735.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <OFCC2BF571.D815BBAC-ON88257439.001DC6D6-88257439.001F49AD@us.ibm.com>

In article <OFCC2BF571.D815BBAC-ON88257439.001DC6D6-88257439.001F49AD@us.ibm.com> (at Sun, 27 Apr 2008 23:41:51 -0600), David Stevens <dlstevens@us.ibm.com> says:

> This patch adds support for getsockopt for MCAST_MSFILTER for
> both IPv4 and IPv6. It depends on the previous setsockopt patch,
> and uses the same method. In addition, there are these cleanups
> included for the setsockopt patch:
> 
> 1) added missing "__user" for kgsr and kgf pointers
> 2) verify read for only GROUP_FILTER_SIZE(0). The group_filter
>         structure definition (via RFC) includes space for one source
>         in the source list array, but that source need not be present.
>         So, sizeof(group_filter) > GROUP_FILTER_SIZE(0). Fixed
>         the user read-check for minimum length to use the smaller size.
> 3) remove unneeded "&" for gf_slist addresses

IMHO, It's much better to split into 2 pathces - bug fixes and
getsockopt() support...

--yoshfuji

  reply	other threads:[~2008-04-28  6:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28  5:41 [PATCH] add compat support for getsockopt (MCAST_MSFILTER) David Stevens
2008-04-28  6:36 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2008-04-28  6:54   ` David Stevens
2008-04-28  7:52     ` YOSHIFUJI Hideaki / 吉藤英明
2008-04-29 10:23       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428.153650.57555735.yoshfuji@linux-ipv6.org \
    --to=yoshfuji@linux-ipv6.org \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox