Re: [PATCH][NET_SCHED] sch_sfq: prevent unnecessary reordering

[Jarek Poplawski <jarkao2@gmail.com>]

David Miller wrote, On 04/28/2008 11:03 AM:
...
>> [NET_SCHED] sch_sfq: prevent unnecessary reordering
>>
>> Current check of queue limit in sfq_enqueue() isn't optimal: there
>> is really not much more needed to prevent unnecessary dropping and
>> possible reordering.
>>
>>
>> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
> 
> I'll let Patrick review this one first, too.

Very wise decision! (As usual.)

But, after rethinking, I've to withdraw this patch too. Sorry!

It looks like the patch could be quite right and should save sometimes
a few cpu cycles, but the subject and the comment are wrong: it doesn't
prevent reordering, but simply adding and later dropping the same
packet. So, the gain is less than planned. (Anyway, if somebody thinks
it's useful, I could resend it after changing...)

Thanks,
Jarek P.