From: Ingo Molnar <mingo@elte.hu>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage
Date: Tue, 29 Apr 2008 17:14:03 +0200 [thread overview]
Message-ID: <20080429151403.GA19410@elte.hu> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC32904F9F13E@orsmsx414.amr.corp.intel.com>
* Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@intel.com> wrote:
> > * PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com> wrote:
> >
> > > This bug was introduced in the 2.6.24 i386/x86_64 tree merge, [...]
> >
> > that's wrong, that code was there in v2.6.23 too - and it wasnt
> > touched in the unification. Why do you think it was introduced in
> > the i386/x86_64 tree merge?
>
> 2.6.23.17 didn't have the used_vectors bitmap. The first time I could
> find it used was in 2.6.24. Where was the code existing in 2.6.23?
> The addition may have not been part of the merge, but it was
> definitely introduced in the same timeframe, meaning the 2.6.24
> release timeframe.
that change came in via lguest (commit dbeb2be2), not the 32-bit/64-bit
x86 unification. Lguest is a new feature in 2.6.24 and this side-effect
of it was not known until you fixed it - thanks for that!
So i was just splitting hairs over your statement that it was due to the
unification :-)
Ingo
next prev parent reply other threads:[~2008-04-29 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 0:58 [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage PJ Waskiewicz
2008-04-28 19:09 ` Eric W. Biederman
2008-04-28 21:27 ` Waskiewicz Jr, Peter P
2008-04-28 20:30 ` Thomas Gleixner
2008-04-28 20:42 ` Waskiewicz Jr, Peter P
2008-04-28 21:16 ` Thomas Gleixner
2008-04-28 21:21 ` Waskiewicz Jr, Peter P
2008-04-29 10:21 ` Ingo Molnar
2008-04-29 15:07 ` Waskiewicz Jr, Peter P
2008-04-29 15:14 ` Ingo Molnar [this message]
2008-04-30 0:16 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429151403.GA19410@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).