From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jarek Poplawski <jarkao2@gmail.com>
Subject: Re: [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing
Date: Wed, 30 Apr 2008 09:04:14 +0200
Message-ID: <20080430070414.GA6828@ami.dom.local>
References: <20080427142216.GB7480@ami.dom.local> <4814C618.3050506@trash.net> <20080427203630.GA9648@ami.dom.local> <4815D8D9.5020201@trash.net> <20080428145837.GB2870@ami.dom.local> <20080429205341.GA4356@ami.dom.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
To: Patrick McHardy <kaber@trash.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from nf-out-0910.google.com ([64.233.182.187]:30951 "EHLO
	nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753277AbYD3HGF (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 30 Apr 2008 03:06:05 -0400
Received: by nf-out-0910.google.com with SMTP id d3so183716nfc.21
        for <netdev@vger.kernel.org>; Wed, 30 Apr 2008 00:06:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20080429205341.GA4356@ami.dom.local>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Apr 29, 2008 at 10:53:41PM +0200, Jarek Poplawski wrote:
...
> So it's really by design! (I don't know why I missed this, and why

...Hmm..., actually this is the place:

sfq_enqueue(struct sk_buff *skb, struct Qdisc *sch)
{
...
	x = q->ht[hash];
	if (x == SFQ_DEPTH) {
		q->ht[hash] = x = q->dep[SFQ_DEPTH].next;
...

sfq counts on free slot always available here.

Regards,
Jarek P.