* [PATCH] Wrong list_lock argument in rose_node seqops
@ 2008-04-30 20:08 Bernard Pidoux
2008-05-03 0:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Bernard Pidoux @ 2008-04-30 20:08 UTC (permalink / raw)
To: David Miller; +Cc: Ralf Baechle DL5RB, Linux Netdev List, linux-hams
In rose_node_start() as well as in rose_node_stop()
__acquires() and spin_lock_bh() were wrongly passing
rose_neigh_list_lock instead of rose_node_list_lock arguments.
Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>
---
net/rose/rose_route.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
index 5053a53..bd59387 100644
--- a/net/rose/rose_route.c
+++ b/net/rose/rose_route.c
@@ -1066,12 +1066,12 @@ out:
#ifdef CONFIG_PROC_FS
static void *rose_node_start(struct seq_file *seq, loff_t *pos)
- __acquires(rose_neigh_list_lock)
+ __acquires(rose_node_list_lock)
{
struct rose_node *rose_node;
int i = 1;
- spin_lock_bh(&rose_neigh_list_lock);
+ spin_lock_bh(&rose_node_list_lock);
if (*pos == 0)
return SEQ_START_TOKEN;
@@ -1090,9 +1090,9 @@ static void *rose_node_next(struct seq_file *seq, void *v, loff_t *pos)
}
static void rose_node_stop(struct seq_file *seq, void *v)
- __releases(rose_neigh_list_lock)
+ __releases(rose_node_list_lock)
{
- spin_unlock_bh(&rose_neigh_list_lock);
+ spin_unlock_bh(&rose_node_list_lock);
}
static int rose_node_show(struct seq_file *seq, void *v)
--
1.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Wrong list_lock argument in rose_node seqops
2008-04-30 20:08 [PATCH] Wrong list_lock argument in rose_node seqops Bernard Pidoux
@ 2008-05-03 0:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-05-03 0:03 UTC (permalink / raw)
To: bpidoux; +Cc: ralf, netdev, linux-hams
From: Bernard Pidoux <bpidoux@free.fr>
Date: Wed, 30 Apr 2008 22:08:56 +0200
> In rose_node_start() as well as in rose_node_stop()
> __acquires() and spin_lock_bh() were wrongly passing
> rose_neigh_list_lock instead of rose_node_list_lock arguments.
>
> Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>
Applied, good catch.
Thanks Bernard.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-03 0:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-30 20:08 [PATCH] Wrong list_lock argument in rose_node seqops Bernard Pidoux
2008-05-03 0:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).