netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: bhutchings@solarflare.com, kmansley@solarflare.com,
	shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs
Date: Thu, 01 May 2008 03:51:08 -0700 (PDT)	[thread overview]
Message-ID: <20080501.035108.190262472.davem@davemloft.net> (raw)
In-Reply-To: <20080501103854.GA7285@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 1 May 2008 18:38:54 +0800

> I still don't understand why we can't forward LRO packets.  It
> should be no different to forwarding GSO packets if it's properly
> constructed.

Hmmm, you should be right.

On the output path, if the device can't GSO, we'll software
un-GSO it.

Perhaps the issue is that it's expensive to do that, and thus
it could harm routing performance in such cases.

  parent reply	other threads:[~2008-05-01 10:51 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 21:48 [PATCH 0/2] Disable forwarding of LRO skbs Ben Hutchings
2008-04-30 21:51 ` [PATCH 1/2] " Ben Hutchings
2008-05-01  9:51   ` David Miller
2008-04-30 21:54 ` [PATCH 2/2] " Ben Hutchings
2008-04-30 21:58 ` [PATCH 0/2] " David Miller
2008-05-01 10:19   ` Herbert Xu
2008-05-01 10:34     ` David Miller
2008-05-01 10:38       ` Herbert Xu
2008-05-01 10:45         ` Herbert Xu
2008-05-01 10:52           ` David Miller
2008-05-01 10:55             ` Herbert Xu
2008-05-01 11:04               ` Kieran Mansley
2008-05-01 10:51         ` David Miller [this message]
2008-05-01 10:53           ` Herbert Xu
2008-05-01 11:00     ` Kieran Mansley
2008-05-01 11:06       ` Herbert Xu
2008-05-01 10:42 ` Herbert Xu
2008-05-01 11:02   ` Ben Hutchings
2008-05-01 11:08     ` Kieran Mansley
2008-05-01 11:12       ` Herbert Xu
2008-05-01 11:18         ` Kieran Mansley
2008-05-01 11:37           ` Herbert Xu
2008-05-01 12:08             ` Ben Hutchings
2008-05-01 12:19               ` Herbert Xu
2008-05-12 14:48                 ` Ben Hutchings
2008-05-01 14:06     ` Herbert Xu
2008-06-15  0:51       ` Ben Hutchings
2008-06-15  1:46         ` Ben Hutchings
2008-06-15  3:38           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080501.035108.190262472.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kmansley@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).