From: Ben Hutchings <bhutchings@solarflare.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Kieran Mansley <kmansley@solarflare.com>,
davem@davemloft.net, shemminger@vyatta.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs
Date: Thu, 1 May 2008 13:08:51 +0100 [thread overview]
Message-ID: <20080501120850.GH14219@solarflare.com> (raw)
In-Reply-To: <20080501113716.GA7955@gondor.apana.org.au>
Herbert Xu wrote:
> On Thu, May 01, 2008 at 12:18:08PM +0100, Kieran Mansley wrote:
> >
> > If I remember rightly it also gets upset when it comes to split the
> > packet because the frag_list is already in use; it expects this not to
> > be the case for GSO but it's valid for an LRO packet to do this I think.
> > I don't think there's anything fundamentally difficult here, it's just
> > that the code has never been written to cope.
>
> Oh so LRO packets still preserve the original packet boundaries?
> That's even easier. We could just make the GSO output code detect
> the presence of frag_list and fragment based on that.
Depending on the driver, the packets may be received into skbs which are
then attached to frag_list, or into page buffers which go in the frags
array. If most packets can be merged by LRO, deferring skb allocation
and using the frags array is a performance win.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-05-01 12:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 21:48 [PATCH 0/2] Disable forwarding of LRO skbs Ben Hutchings
2008-04-30 21:51 ` [PATCH 1/2] " Ben Hutchings
2008-05-01 9:51 ` David Miller
2008-04-30 21:54 ` [PATCH 2/2] " Ben Hutchings
2008-04-30 21:58 ` [PATCH 0/2] " David Miller
2008-05-01 10:19 ` Herbert Xu
2008-05-01 10:34 ` David Miller
2008-05-01 10:38 ` Herbert Xu
2008-05-01 10:45 ` Herbert Xu
2008-05-01 10:52 ` David Miller
2008-05-01 10:55 ` Herbert Xu
2008-05-01 11:04 ` Kieran Mansley
2008-05-01 10:51 ` David Miller
2008-05-01 10:53 ` Herbert Xu
2008-05-01 11:00 ` Kieran Mansley
2008-05-01 11:06 ` Herbert Xu
2008-05-01 10:42 ` Herbert Xu
2008-05-01 11:02 ` Ben Hutchings
2008-05-01 11:08 ` Kieran Mansley
2008-05-01 11:12 ` Herbert Xu
2008-05-01 11:18 ` Kieran Mansley
2008-05-01 11:37 ` Herbert Xu
2008-05-01 12:08 ` Ben Hutchings [this message]
2008-05-01 12:19 ` Herbert Xu
2008-05-12 14:48 ` Ben Hutchings
2008-05-01 14:06 ` Herbert Xu
2008-06-15 0:51 ` Ben Hutchings
2008-06-15 1:46 ` Ben Hutchings
2008-06-15 3:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501120850.GH14219@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kmansley@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).