From: Ondrej Zajicek <santiago@crfreenet.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Ondrej Zajicek <santiago@crfreenet.org>,
Jiri Slaby <jirislaby@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, rl@hellgate.ch
Subject: Re: [PATCH] via-rhine: suspend/resume bugfix
Date: Fri, 2 May 2008 22:57:35 +0200 [thread overview]
Message-ID: <20080502205734.GA5988@localhost.localdomain> (raw)
In-Reply-To: <20080503002655.GA3956@ucw.cz>
On Fri, May 02, 2008 at 10:32:46PM +0200, Pavel Machek wrote:
> > Hmm, i will fix it. And i found that the patch might break
> > wakeup-on-LAN. So please discard it.
>
> IRQ line should not be neccessary for WoL...?
IRQ line is not neccessary (i hope), but the patch puts this to
suspend path:
/* Switch to loopback mode to avoid hardware races. */
iowrite8(rp->tx_thresh | 0x02, ioaddr + TxConfig);
/* Disable interrupts by clearing the interrupt mask. */
iowrite16(0x0000, ioaddr + IntrEnable);
/* Stop the chip's Tx and Rx processes. */
iowrite16(CmdStop, ioaddr + ChipCmd);
(this was copied from shutdown path of the driver)
I suppose that the first one might break WoL. Unfortunately
on my hardware the WoL don't work even without the patch.
--
Elen sila lumenn' omentielvo
Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
prev parent reply other threads:[~2008-05-02 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 7:13 [PATCH] via-rhine: suspend/resume bugfix Ondrej Zajicek
2008-04-27 8:59 ` Jiri Slaby
2008-04-27 9:58 ` Ondrej Zajicek
2008-05-02 20:32 ` Pavel Machek
2008-05-02 20:57 ` Ondrej Zajicek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502205734.GA5988@localhost.localdomain \
--to=santiago@crfreenet.org \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).