From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [NET] fix useless comment reference loop
Date: Sat, 03 May 2008 20:57:32 -0700 (PDT) [thread overview]
Message-ID: <20080503.205732.48777773.davem@davemloft.net> (raw)
In-Reply-To: <1209852342.3673.16.camel@johannes.berg>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Sun, 04 May 2008 00:05:42 +0200
> include/linux/skbuff.h says:
> /* These elements must be at the end, see alloc_skb() for details. */
>
> net/core/skbuff.c says:
> * See comment in sk_buff definition, just before the 'tail' member
>
> This patch contains my guess as to the actual reason rather than a
> dead comment reference loop.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Patch applied, thanks.
This is an example of why I'm personally a comment minimalist.
They tend to rot, confuse people, and often just duplicate what
is obvious from the code (although not in this case).
prev parent reply other threads:[~2008-05-04 3:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 22:05 [PATCH] [NET] fix useless comment reference loop Johannes Berg
2008-05-04 3:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503.205732.48777773.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox