From: David Miller <davem@davemloft.net>
To: matheos.worku@sun.com
Cc: netdev@vger.kernel.org
Subject: Neptune regression...
Date: Sat, 03 May 2008 23:52:12 -0700 (PDT) [thread overview]
Message-ID: <20080503.235212.140840235.davem@davemloft.net> (raw)
Matheos, this patch of your's:
commit 7f7c4072ea552f97a0898331322f71986a97299c
Author: Matheos Worku <matheos.worku@sun.com>
Date: Thu Apr 24 21:02:37 2008 -0700
niu: Determine the # of ports from the card's VPD data
[ Fix minor whitespace and coding style stuff... -DaveM ]
Signed-off-by: Matheos Worku <matheos.worku@sun.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Breaks on-board Neptune chips on Maramba systems.
Previously the code in niu_get_and_validate_port() used a default of
"4" ports if the various probing methods failed. Your code removed
that fallback.
This case seems to be what triggers for on-board Maramba chips.
So, for now, I'm going to put the:
if (!parent->num_ports)
parent->num_ports = 4;
back in there to fix the regression. I've validated that this fixes
the problem.
Is there some other mechanism we should be using here to detect the
port count in the Maramba on-board case?
next reply other threads:[~2008-05-04 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 6:52 David Miller [this message]
2008-05-05 20:10 ` Neptune regression Matheos Worku
2008-05-05 21:03 ` David Miller
2008-05-05 21:15 ` Matheos Worku
2008-05-05 22:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503.235212.140840235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=matheos.worku@sun.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).