From: David Miller <davem@davemloft.net>
To: hidave.darkstar@gmail.com
Cc: akpm@linux-foundation.org, paulmck@us.ibm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] __ratelimit rewrite
Date: Sun, 04 May 2008 00:54:33 -0700 (PDT) [thread overview]
Message-ID: <20080504.005433.98511912.davem@davemloft.net> (raw)
In-Reply-To: <20080504070738.GA11832@darkstar.te-china.tietoenator.com>
From: Dave Young <hidave.darkstar@gmail.com>
Date: Sun, 4 May 2008 15:07:38 +0800
Hi Dave,
> @@ -76,8 +76,8 @@ extern void warn_on_slowpath(const char
> unlikely(__ret_warn_once); \
> })
>
> -#define WARN_ON_SECS(condition, state, secs) \
> - WARN_ON((condition) && __ratelimit(state))
> +#define WARN_ON_RATELIMIT(condition, state) \
> + WARN_ON((condition) && __ratelimit(state));
>
> #ifdef CONFIG_SMP
> # define WARN_ON_SMP(x) WARN_ON(x)
Are you sure you want that new semicolon there?
if (foo)
WARN_ON_RATELIMIT(...);
else
will result in a compile error.
next prev parent reply other threads:[~2008-05-04 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 7:07 [PATCH -mm] __ratelimit rewrite Dave Young
2008-05-04 7:54 ` David Miller [this message]
2008-05-04 8:13 ` Dave Young
2008-05-04 14:47 ` Joe Perches
2008-05-05 1:37 ` Dave Young
2008-05-05 2:25 ` Joe Perches
2008-05-05 2:58 ` Dave Young
2008-05-05 2:52 ` Joe Perches
2008-05-05 5:18 ` Dave Young
2008-05-05 5:20 ` David Miller
2008-05-05 2:27 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504.005433.98511912.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).