From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: johannes@sipsolutions.net, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH][MAC80211]: Do not free net device after it is unregistered.
Date: Sun, 04 May 2008 17:59:43 -0700 (PDT) [thread overview]
Message-ID: <20080504.175943.181438923.davem@davemloft.net> (raw)
In-Reply-To: <481D5D79.5080702@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Sun, 04 May 2008 10:53:45 +0400
> The error path in ieee80211_register_hw() may call the unregister_netdev()
> and right after it - the free_netdev(), which is wrong, since the
> unregister releases the device itself.
>
> So the proposed fix is to NULL the local->mdev after unregister is done
> and check this before calling free_netdev().
>
> I checked - no code uses the local->mdev after unregister in this error
> path (but even if some did this would be a BUG).
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
I'll take this.
Applied, thanks Pavel.
prev parent reply other threads:[~2008-05-05 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 6:53 [PATCH][MAC80211]: Do not free net device after it is unregistered Pavel Emelyanov
2008-05-05 0:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504.175943.181438923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).