From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [NET] warn when accounting an skb that already has a destructor
Date: Mon, 05 May 2008 00:20:06 -0700 (PDT) [thread overview]
Message-ID: <20080505.002006.225975612.davem@davemloft.net> (raw)
In-Reply-To: <1209925940.3655.17.camel@johannes.berg>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Sun, 04 May 2008 20:32:20 +0200
> This makes the networking layer warn when something tries to
> charge an skb to a socket that already is charged to another
> socket (or has a destructor from somewhere else.)
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
I completely agree that this a correct assertion, that
absolutely should never happen in the current tree.
But if we are going to do this, I'm pretty sure we'll
need to uninline these two routines.
I'll leave it up to you, if you think it's still worthwhile
with the uninlining, please resubmit :-)
next prev parent reply other threads:[~2008-05-05 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 18:32 [PATCH] [NET] warn when accounting an skb that already has a destructor Johannes Berg
2008-05-05 7:20 ` David Miller [this message]
2008-05-05 7:31 ` Johannes Berg
2008-05-05 7:40 ` David Miller
2008-05-05 9:43 ` Ilpo Järvinen
2008-05-05 11:37 ` Johannes Berg
2008-05-05 11:58 ` Ilpo Järvinen
2008-05-05 12:04 ` Johannes Berg
2008-05-05 19:08 ` David Miller
2008-05-05 21:57 ` Arnaldo Carvalho de Melo
2008-05-06 8:39 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505.002006.225975612.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).