From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: johannes@sipsolutions.net, netdev@vger.kernel.org
Subject: Re: [PATCH] [NET] warn when accounting an skb that already has a destructor
Date: Mon, 05 May 2008 12:08:11 -0700 (PDT) [thread overview]
Message-ID: <20080505.120811.211603587.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0805051241240.21115@wrl-59.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 5 May 2008 12:43:25 +0300 (EEST)
> On Mon, 5 May 2008, David Miller wrote:
>
> > From: Johannes Berg <johannes@sipsolutions.net>
> > Date: Mon, 05 May 2008 09:31:15 +0200
> >
> > > If we decide to uninline those functions for another reason (used too
> > > much, code size, ...) then we can still do that.
> >
> > Agreed.
>
> According to my measurements the size bloat of those two is
> (x86/32bit, gcc 4.1.2 redhat something):
>
> -1091 40 funcs, 89 +, 1180 -, diff: -1091 --- skb_set_owner_r
> -495 46 funcs, 70 +, 565 -, diff: -495 --- skb_set_owner_w
That's not too bad, but adding the WARN_ON() we're discussing
will plump that up a bit, percentage wise, which is why I
said we should inline it in such a case.
next prev parent reply other threads:[~2008-05-05 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 18:32 [PATCH] [NET] warn when accounting an skb that already has a destructor Johannes Berg
2008-05-05 7:20 ` David Miller
2008-05-05 7:31 ` Johannes Berg
2008-05-05 7:40 ` David Miller
2008-05-05 9:43 ` Ilpo Järvinen
2008-05-05 11:37 ` Johannes Berg
2008-05-05 11:58 ` Ilpo Järvinen
2008-05-05 12:04 ` Johannes Berg
2008-05-05 19:08 ` David Miller [this message]
2008-05-05 21:57 ` Arnaldo Carvalho de Melo
2008-05-06 8:39 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505.120811.211603587.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).