From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC v2] mac80211: assign needed_headroom/tailroom for netdevs Date: Mon, 05 May 2008 17:08:05 -0700 (PDT) Message-ID: <20080505.170805.127854312.davem@davemloft.net> References: <1210029835.8012.30.camel@johannes.berg> <20080505.163916.239187195.davem@davemloft.net> <1210032076.8012.49.camel@johannes.berg> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: tomasw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org To: johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org Return-path: In-Reply-To: <1210032076.8012.49.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Johannes Berg Date: Tue, 06 May 2008 02:01:16 +0200 > Right. I just checked, and realised I remembered wrongly, wpa_supplicant > actually binds the socket to the ethertype it wants so > dev_queue_xmit_nit() shouldn't be called. I'll have to check why I got > so many cloned packets, best see if it still happens with the > header_cloned() change. skb_cloned() is fine, that's what every TCP packet is. skb_header_cloned() is what we expect to be false I look forward to the results of your investigation :-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html