netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Cliburn <jacliburn@bellsouth.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Luca Tettamanti <kronos.it@gmail.com>,
	Chris Snook <csnook@redhat.com>, Jeff Garzik <jeff@garzik.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Christoph Lameter <clameter@sgi.com>,
	torvalds@osdl.org
Subject: Re: atl1 64-bit => 32-bit DMA borkage (reproducible, bisected)
Date: Tue, 6 May 2008 11:02:25 -0500	[thread overview]
Message-ID: <20080506110225.31fd61a4@osprey.hogchain.net> (raw)
In-Reply-To: <20080504211507.GC1040@martell.zuzino.mipt.ru>

On Mon, 5 May 2008 01:15:07 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:

> Looking at how other netdevice drivers:
> 
> 8139too and others checks netif_running() in interrupt handler.
> 
> r8169 has scary "50k$" question comment re irqs disabled after
> interacting with hardware.
> 
> But the r8169 case should be fixed by atlx_irq_disable()?
> 
> Writes to REG_IMR, REG_ISR are commented in atl1_reset_hw(), why?
> (I'll test that soon)

I've tried all the stuff you mentioned above, and more, to prevent the
memory corruption, all to no avail.

I booted with mem=4000M and didn't hit the bug.  I diffed dmesg between
booting with mem=4000M and booting without it, and found that iommu
was being disabled when booting with full memory:

--- dmesg-4000.txt      2008-05-06 10:14:07.000000000 -0500
+++ dmesg-4096.txt      2008-05-06 10:09:19.000000000 -0500
@@ -1,5 +1,5 @@
 Linux version 2.6.26-rc1 (jcliburn@finch.hogchain.net) (gcc version 4.1.2 20070
925 (Red Hat 4.1.2-27)) #4 SMP Mon May 5 18:03:48 CDT 2008
-Command line: ro root=LABEL=/1 console=ttyS0,38400 console=tty0 slub_debug=FZPU mem=4000M
+Command line: ro root=LABEL=/1 console=ttyS0,38400 console=tty0 slub_debug=FZPU
[...]
+Looks like a VIA chipset. Disabling IOMMU. Override with iommu=allowed
[...]

So I then booted with iommu=allowed.  No errors.  Can't hit the bug to
save my life.

Why would disabling iommu cause the atl1 driver to write over poisoned
memory?

Alexey, can you please try booting with iommu=allowed and see if you
avoid the problem?

Thanks,
Jay

  parent reply	other threads:[~2008-05-06 16:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080410203354.f0a6f464.akpm@linux-foundation.org>
     [not found] ` <20080413204422.GA5136@martell.zuzino.mipt.ru>
     [not found]   ` <84144f020804140901p1c076fd2q73e3effe7cd96da3@mail.gmail.com>
     [not found]     ` <Pine.LNX.4.64.0804141050550.6296@schroedinger.engr.sgi.com>
     [not found]       ` <20080414183221.GA5234@martell.zuzino.mipt.ru>
2008-04-14 19:56         ` 2.6.25-rc8-mm2: FIX kmalloc-2048 (was Re: 2.6.25-rc8-mm2: IP: [<ffffffff802868f9>] __kmalloc+0x69/0x110) Alexey Dobriyan
2008-04-14 20:05           ` Christoph Lameter
2008-04-19 11:17             ` Alexey Dobriyan
2008-04-19 14:45               ` atl1 64-bit => 32-bit DMA borkage (reproducible, bisected) Alexey Dobriyan
2008-04-20  2:54                 ` Jay Cliburn
2008-04-20 11:14                   ` Alexey Dobriyan
2008-04-20 11:06                     ` Jay Cliburn
2008-04-20 12:26                       ` Alexey Dobriyan
2008-04-20 18:37                         ` Jay Cliburn
2008-04-20 20:55                           ` Alexey Dobriyan
2008-04-21 18:42                             ` Chris Snook
2008-04-21 19:56                               ` Alexey Dobriyan
2008-04-22  2:08                             ` Jay Cliburn
2008-04-22 19:02                               ` Alexey Dobriyan
2008-04-26  0:57                               ` Jay Cliburn
2008-04-28  6:42                                 ` Alexey Dobriyan
2008-05-04 21:15                                 ` Alexey Dobriyan
2008-05-05  0:31                                   ` Jay Cliburn
2008-05-05  0:34                                     ` Jay Cliburn
2008-05-06 16:02                                   ` Jay Cliburn [this message]
2008-05-09 19:51                                     ` Alexey Dobriyan
2008-05-09 18:56                                       ` Chris Snook
2008-05-09 20:07                                         ` Alexey Dobriyan
2008-05-09 19:38                                           ` Jay Cliburn
2008-05-10 19:31                                             ` [PATCH] " Alexey Dobriyan
2008-05-11  1:58                                               ` Jay Cliburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506110225.31fd61a4@osprey.hogchain.net \
    --to=jacliburn@bellsouth.net \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=csnook@redhat.com \
    --cc=jeff@garzik.org \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).