* [PATCH] sky2: fix simple define thinko
@ 2008-05-06 21:34 Jesse Brandeburg
2008-05-06 23:18 ` Stephen Hemminger
2008-05-13 5:17 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Jesse Brandeburg @ 2008-05-06 21:34 UTC (permalink / raw)
To: jeff; +Cc: netdev, Jesse Brandeburg, Stephen Hemminger
noticed while browsing code, apparent thinko. compile tested only.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
CC: Stephen Hemminger <shemminger@linux-foundation.org>
---
drivers/net/sky2.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sky2.h b/drivers/net/sky2.h
index 7bb3ba9..c0a5eea 100644
--- a/drivers/net/sky2.h
+++ b/drivers/net/sky2.h
@@ -1966,13 +1966,13 @@ struct sky2_status_le {
struct tx_ring_info {
struct sk_buff *skb;
DECLARE_PCI_UNMAP_ADDR(mapaddr);
- DECLARE_PCI_UNMAP_ADDR(maplen);
+ DECLARE_PCI_UNMAP_LEN(maplen);
};
struct rx_ring_info {
struct sk_buff *skb;
dma_addr_t data_addr;
- DECLARE_PCI_UNMAP_ADDR(data_size);
+ DECLARE_PCI_UNMAP_LEN(data_size);
dma_addr_t frag_addr[ETH_JUMBO_MTU >> PAGE_SHIFT];
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sky2: fix simple define thinko
2008-05-06 21:34 [PATCH] sky2: fix simple define thinko Jesse Brandeburg
@ 2008-05-06 23:18 ` Stephen Hemminger
2008-05-13 5:17 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2008-05-06 23:18 UTC (permalink / raw)
To: Jesse Brandeburg; +Cc: jeff, netdev, Jesse Brandeburg
On Tue, 06 May 2008 14:34:35 -0700
Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:
> noticed while browsing code, apparent thinko. compile tested only.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Stephen Hemminger <shemminger@linux-foundation.org>
> ---
>
> drivers/net/sky2.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/net/sky2.h b/drivers/net/sky2.h
> index 7bb3ba9..c0a5eea 100644
> --- a/drivers/net/sky2.h
> +++ b/drivers/net/sky2.h
> @@ -1966,13 +1966,13 @@ struct sky2_status_le {
> struct tx_ring_info {
> struct sk_buff *skb;
> DECLARE_PCI_UNMAP_ADDR(mapaddr);
> - DECLARE_PCI_UNMAP_ADDR(maplen);
> + DECLARE_PCI_UNMAP_LEN(maplen);
> };
>
> struct rx_ring_info {
> struct sk_buff *skb;
> dma_addr_t data_addr;
> - DECLARE_PCI_UNMAP_ADDR(data_size);
> + DECLARE_PCI_UNMAP_LEN(data_size);
> dma_addr_t frag_addr[ETH_JUMBO_MTU >> PAGE_SHIFT];
> };
>
>
Yes, this looks okay. We were safe up till now because ADDR > LEN
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sky2: fix simple define thinko
2008-05-06 21:34 [PATCH] sky2: fix simple define thinko Jesse Brandeburg
2008-05-06 23:18 ` Stephen Hemminger
@ 2008-05-13 5:17 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-05-13 5:17 UTC (permalink / raw)
To: Jesse Brandeburg; +Cc: netdev, Stephen Hemminger
Jesse Brandeburg wrote:
> noticed while browsing code, apparent thinko. compile tested only.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Stephen Hemminger <shemminger@linux-foundation.org>
> ---
>
> drivers/net/sky2.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-13 5:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-06 21:34 [PATCH] sky2: fix simple define thinko Jesse Brandeburg
2008-05-06 23:18 ` Stephen Hemminger
2008-05-13 5:17 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).