From: Andrew Morton <akpm@linux-foundation.org>
To: jdassen@debian.org
Cc: bugme-daemon@bugzilla.kernel.org, netdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 10611] New: Incorrect RFC section reference in comment
Date: Tue, 6 May 2008 23:33:51 -0700 [thread overview]
Message-ID: <20080506233351.1fe19fe6.akpm@linux-foundation.org> (raw)
In-Reply-To: <bug-10611-10286@http.bugzilla.kernel.org/>
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Tue, 6 May 2008 23:25:14 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=10611
>
> Summary: Incorrect RFC section reference in comment
> Product: Networking
> Version: 2.5
> KernelVersion: master branch
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: IPV4
> AssignedTo: shemminger@linux-foundation.org
> ReportedBy: jdassen@debian.org
>
>
> Problem Description:
>
> RFC 1122 does not have a section 3.1.2.2. The requirement to silently
> discard packets with a bad checksum is in section 3.2.1.2 instead.
>
> Proposed patch:
>
> diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
> index 212734c..5bdb8f4 100644
> --- a/net/ipv4/ip_input.c
> +++ b/net/ipv4/ip_input.c
> @@ -394,7 +394,7 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev,
> struct packet_type *pt,
> iph = skb->nh.iph;
>
> /*
> - * RFC1122: 3.1.2.2 MUST silently discard any IP frame that fails
> the checksum.
> + * RFC1122: 3.2.1.2 MUST silently discard any IP frame that fails
> the checksum.
> *
> * Is the datagram acceptable?
> *
>
>
Thanks, but we much prefer that patches be handled via email. Can you
please resend the patch as a reply-to-all to this email, along with a
signed-off-by: as per Documentation/SubmittingPatches?
next parent reply other threads:[~2008-05-07 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-10611-10286@http.bugzilla.kernel.org/>
2008-05-07 6:33 ` Andrew Morton [this message]
2008-05-07 7:24 ` [PATCH] net/ipv4: Correct RFC 1122 section reference in comment J.H.M. Dassen (Ray)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506233351.1fe19fe6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=jdassen@debian.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).