netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: damon@damtek.com, 213081@bugs.launchpad.net,
	478062@bugs.debian.org, netdev@vger.kernel.org
Subject: Re: Fix FRTO+NewReno problem
Date: Thu, 08 May 2008 01:10:21 -0700 (PDT)	[thread overview]
Message-ID: <20080508.011021.14498289.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0805072357240.23091@wrl-59.cs.helsinki.fi>

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Thu, 8 May 2008 01:26:59 +0300 (EEST)

> [PATCH] [TCP] FRTO: SACK variant is errorneously used with NewReno

I applied this with a minor coding style fixup.

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Thu, 8 May 2008 01:26:59 +0300 (EEST)

> +static int tcp_is_sackfrto(const struct tcp_sock *tp) {
> +	return (sysctl_tcp_frto == 0x2) && !tcp_is_reno(tp);
> +}
> +

Should be:

static int tcp_is_sackfrto(const struct tcp_sock *tp)
{
	return (sysctl_tcp_frto == 0x2) && !tcp_is_reno(tp);
}

I will also queue this up to -stable, thanks so much for
this bug fix!

  reply	other threads:[~2008-05-08  8:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <48207F06.50306@damtek.com>
     [not found] ` <Pine.LNX.4.64.0805061912350.8965@wrl-59.cs.helsinki.fi>
     [not found]   ` <4821C37A.7040306@damtek.com>
2008-05-07 22:26     ` Fix FRTO+NewReno problem (Was: Re: This has a work around) Ilpo Järvinen
2008-05-08  8:10       ` David Miller [this message]
2008-05-08 16:50       ` Bug#478062: " Damon L. Chesser
2008-05-08 17:05       ` Damon L. Chesser
2008-05-08 18:16       ` Damon L. Chesser
2008-05-08 20:42         ` Ilpo Järvinen
2008-05-12 10:08           ` Ilpo Järvinen
     [not found]             ` <4828279C.3010102@damtek.com>
2008-05-12 11:32               ` Ilpo Järvinen
2008-05-12 11:55                 ` Damon L. Chesser
2008-05-12 12:07                   ` Ilpo Järvinen
2008-05-12 13:44                     ` Damon L. Chesser
2008-05-12 14:35                       ` Ilpo Järvinen
2008-05-12 16:40                         ` Ilpo Järvinen
2008-05-12 17:02                         ` Damon L. Chesser
2008-05-12 18:23                           ` Ilpo Järvinen
2008-05-12 18:39                         ` Damon L. Chesser
2008-05-12 19:12                           ` Ilpo Järvinen
2008-05-12 19:18                             ` Damon L. Chesser
2008-05-12 19:25                               ` Ilpo Järvinen
2008-05-12 22:48                             ` Fix FRTO+NewReno problem David Miller
2008-05-13  9:42                               ` Ilpo Järvinen
2008-05-13  9:49                                 ` David Miller
2008-05-13 10:04                                   ` Ilpo Järvinen
2008-05-13 10:08                                     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080508.011021.14498289.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=213081@bugs.launchpad.net \
    --cc=478062@bugs.debian.org \
    --cc=damon@damtek.com \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).