From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karsten Keil Subject: Re: [PATCH] Remove cli()/sti() calls from HYSDN driver. Date: Thu, 8 May 2008 10:33:53 +0200 Message-ID: <20080508083353.GA18187@pingi.kke.suse.de> References: <1209673012-10500-1-git-send-email-mark.asselstine@windriver.com> <20080507153800.16537fbc.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Asselstine , kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, kkeil@suse.de, asselsm@gmail.com To: Andrew Morton Return-path: Received: from mail.suse.de ([195.135.220.2]:38037 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbYEHId4 (ORCPT ); Thu, 8 May 2008 04:33:56 -0400 Content-Disposition: inline In-Reply-To: <20080507153800.16537fbc.akpm@linux-foundation.org> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, May 07, 2008 at 03:38:00PM -0700, Andrew Morton wrote: > On Thu, 1 May 2008 16:16:52 -0400 > Mark Asselstine wrote: > > > >From looking at this driver the use of cli()/sti() within the do/while > > was a way to ensure interrupts were only disabled for short periods of > > time while the bulk of the time interrupts were free to occur. The > > use of the spin lock has eliminated the need to play with interrupts > > in this way while still allowing for IO to be protected. > > OK. If we still want the interrupt-latency optimisation then we should > switch over to using local_irq_disable(). But probably nobody cares. > > > The remaining 3 sti() calls seem unneeded now that at no other point > > in the driver is there a call to cli(). > > > > Signed-off-by: Mark Asselstine > > --- > > drivers/isdn/hysdn/boardergo.c | 14 +++++--------- > > So... can we now do this? > I think so. > > --- a/drivers/isdn/hysdn/Kconfig~a > +++ a/drivers/isdn/hysdn/Kconfig > @@ -3,7 +3,7 @@ > # > config HYSDN > tristate "Hypercope HYSDN cards (Champ, Ergo, Metro) support (module only)" > - depends on m && PROC_FS && PCI && BROKEN_ON_SMP > + depends on m && PROC_FS && PCI > help > Say Y here if you have one of Hypercope's active PCI ISDN cards > Champ, Ergo and Metro. You will then get a module called hysdn. > _ -- Karsten Keil SuSE Labs ISDN and VOIP development SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)