From: Andrew Morton <akpm@linux-foundation.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: jeff@garzik.org, ben-linux@fluff.org, netdev@vger.kernel.org
Subject: Re: DM9000: Use delayed work to update MII PHY state
Date: Thu, 8 May 2008 13:11:02 -0700 [thread overview]
Message-ID: <20080508131102.2c8c3cab.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080508103642.GE30439@fluff.org.uk>
On Thu, 8 May 2008 11:36:42 +0100
Ben Dooks <ben-linux@fluff.org> wrote:
> @@ -879,6 +903,8 @@ dm9000_stop(struct net_device *ndev)
> if (netif_msg_ifdown(db))
> dev_dbg(db->dev, "shutting down %s\n", ndev->name);
>
> + cancel_delayed_work(&db->phy_poll);
I think this should be cancel_delayed_work_sync().
next prev parent reply other threads:[~2008-05-08 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 15:13 DM9000 patches Ben Dooks
2008-04-28 15:21 ` Jeff Garzik
2008-05-06 16:25 ` Jeff Garzik
2008-05-08 10:28 ` Ben Dooks
2008-05-08 10:33 ` DM9000: Add __devinit and __devexit attributes to probe and remove Ben Dooks
2008-05-13 5:18 ` Jeff Garzik
2008-05-08 10:35 ` DM9000: Update and fix driver debugging messages Ben Dooks
2008-05-08 10:36 ` DM9000: Use delayed work to update MII PHY state Ben Dooks
2008-05-08 20:11 ` Andrew Morton [this message]
2008-05-08 20:18 ` Andrew Morton
2008-05-12 20:27 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508131102.2c8c3cab.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).