netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] net: hso driver uses rfkill functions
@ 2008-05-09 16:51 Randy Dunlap
  2008-05-12  8:29 ` Paulius Zaleckas
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-05-09 16:51 UTC (permalink / raw)
  To: netdev, ajb; +Cc: jgarzik, akpm

From: Randy Dunlap <randy.dunlap@oracle.com>

hso driver uses rfkill functions so should either depend on RFKILL
or select it.  This patch uses depends on RFKILL.

drivers/built-in.o: In function `hso_disconnect':
hso.c:(.text+0x868c9): undefined reference to `rfkill_unregister'
drivers/built-in.o: In function `hso_probe':
hso.c:(.text+0x88226): undefined reference to `rfkill_allocate'
hso.c:(.text+0x8829e): undefined reference to `rfkill_register'
hso.c:(.text+0x8860f): undefined reference to `rfkill_free'
make[1]: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/net/usb/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- next-20080509.orig/drivers/net/usb/Kconfig
+++ next-20080509/drivers/net/usb/Kconfig
@@ -156,7 +156,7 @@ config USB_NET_AX8817X
 
 config USB_HSO
 	tristate "Option USB High Speed Mobile Devices"
-	depends on USB
+	depends on USB && RFKILL
 	default n
 	help
 	  Choose this option if you have an Option HSDPA/HSUPA card.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] net: hso driver uses rfkill functions
  2008-05-09 16:51 [PATCH -next] net: hso driver uses rfkill functions Randy Dunlap
@ 2008-05-12  8:29 ` Paulius Zaleckas
  0 siblings, 0 replies; 2+ messages in thread
From: Paulius Zaleckas @ 2008-05-12  8:29 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: netdev, ajb, jgarzik, akpm, Greg KH

AFAIK Greg has (or he is going to do it) patch for rfkill so no more 
depends or select RFKILL will be needed.

BR,
Paulius Zaleckas

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> hso driver uses rfkill functions so should either depend on RFKILL
> or select it.  This patch uses depends on RFKILL.
> 
> drivers/built-in.o: In function `hso_disconnect':
> hso.c:(.text+0x868c9): undefined reference to `rfkill_unregister'
> drivers/built-in.o: In function `hso_probe':
> hso.c:(.text+0x88226): undefined reference to `rfkill_allocate'
> hso.c:(.text+0x8829e): undefined reference to `rfkill_register'
> hso.c:(.text+0x8860f): undefined reference to `rfkill_free'
> make[1]: *** [.tmp_vmlinux1] Error 1
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/net/usb/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- next-20080509.orig/drivers/net/usb/Kconfig
> +++ next-20080509/drivers/net/usb/Kconfig
> @@ -156,7 +156,7 @@ config USB_NET_AX8817X
>  
>  config USB_HSO
>  	tristate "Option USB High Speed Mobile Devices"
> -	depends on USB
> +	depends on USB && RFKILL
>  	default n
>  	help
>  	  Choose this option if you have an Option HSDPA/HSUPA card.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-12  8:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-09 16:51 [PATCH -next] net: hso driver uses rfkill functions Randy Dunlap
2008-05-12  8:29 ` Paulius Zaleckas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).