* [PATCH net-next-2.6] [TIPC]: Enhancements to name table initialization
@ 2008-05-12 20:33 Allan Stephens
2008-05-12 22:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Allan Stephens @ 2008-05-12 20:33 UTC (permalink / raw)
To: David Miller; +Cc: netdev, allan.stephens
This patch enhances the initialization of TIPC's name table
by removing a pointless spinlock operation, and by using
kcalloc() to detect requests for an oversized name table.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
---
net/tipc/name_table.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
index ac7dfdd..892373e 100644
--- a/net/tipc/name_table.c
+++ b/net/tipc/name_table.c
@@ -1050,15 +1050,12 @@ void tipc_nametbl_dump(void)
int tipc_nametbl_init(void)
{
- int array_size = sizeof(struct hlist_head) * tipc_nametbl_size;
-
- table.types = kzalloc(array_size, GFP_ATOMIC);
+ table.types = kcalloc(tipc_nametbl_size, sizeof(struct hlist_head),
+ GFP_ATOMIC);
if (!table.types)
return -ENOMEM;
- write_lock_bh(&tipc_nametbl_lock);
table.local_publ_count = 0;
- write_unlock_bh(&tipc_nametbl_lock);
return 0;
}
--
1.5.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next-2.6] [TIPC]: Enhancements to name table initialization
2008-05-12 20:33 [PATCH net-next-2.6] [TIPC]: Enhancements to name table initialization Allan Stephens
@ 2008-05-12 22:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-05-12 22:42 UTC (permalink / raw)
To: allan.stephens; +Cc: netdev
From: Allan Stephens <allan.stephens@windriver.com>
Date: Mon, 12 May 2008 16:33:03 -0400
> This patch enhances the initialization of TIPC's name table
> by removing a pointless spinlock operation, and by using
> kcalloc() to detect requests for an oversized name table.
>
> Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-12 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-12 20:33 [PATCH net-next-2.6] [TIPC]: Enhancements to name table initialization Allan Stephens
2008-05-12 22:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).